Skip to content

Commit

Permalink
Char: moxa, remove useless tty functions
Browse files Browse the repository at this point in the history
- moxa_flush_chars -- no code; ldics handle this well
- moxa_put_char -- only wrapper to moxa_write (same code), tty does this
  the same way if tty->driver->put_char is NULL

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Tested-by: Oyvind Aabling <Oyvind.Aabling@uni-c.dk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Jiri Slaby authored and Linus Torvalds committed Apr 30, 2008
1 parent eaa95a8 commit 92d30a9
Showing 1 changed file with 0 additions and 25 deletions.
25 changes: 0 additions & 25 deletions drivers/char/moxa.c
Original file line number Diff line number Diff line change
Expand Up @@ -193,8 +193,6 @@ static int moxa_write(struct tty_struct *, const unsigned char *, int);
static int moxa_write_room(struct tty_struct *);
static void moxa_flush_buffer(struct tty_struct *);
static int moxa_chars_in_buffer(struct tty_struct *);
static void moxa_flush_chars(struct tty_struct *);
static void moxa_put_char(struct tty_struct *, unsigned char);
static void moxa_throttle(struct tty_struct *);
static void moxa_unthrottle(struct tty_struct *);
static void moxa_set_termios(struct tty_struct *, struct ktermios *);
Expand Down Expand Up @@ -391,8 +389,6 @@ static const struct tty_operations moxa_ops = {
.write_room = moxa_write_room,
.flush_buffer = moxa_flush_buffer,
.chars_in_buffer = moxa_chars_in_buffer,
.flush_chars = moxa_flush_chars,
.put_char = moxa_put_char,
.ioctl = moxa_ioctl,
.throttle = moxa_throttle,
.unthrottle = moxa_unthrottle,
Expand Down Expand Up @@ -1284,27 +1280,6 @@ static int moxa_chars_in_buffer(struct tty_struct *tty)
return chars;
}

static void moxa_flush_chars(struct tty_struct *tty)
{
/*
* Don't think I need this, because this is called to empty the TX
* buffer for the 16450, 16550, etc.
*/
}

static void moxa_put_char(struct tty_struct *tty, unsigned char c)
{
struct moxa_port *ch = tty->driver_data;

if (ch == NULL)
return;
spin_lock_bh(&moxa_lock);
MoxaPortWriteData(ch, &c, 1);
spin_unlock_bh(&moxa_lock);

ch->statusflags |= LOWWAIT;
}

static int moxa_tiocmget(struct tty_struct *tty, struct file *file)
{
struct moxa_port *ch;
Expand Down

0 comments on commit 92d30a9

Please sign in to comment.