Skip to content

Commit

Permalink
net/ppp: fix comments - ppp_{sync,asynctty}_receive() may sleep
Browse files Browse the repository at this point in the history
The receive_buf methods of the N_PPP and N_SYNC_PPP line disciplines,
ppp_asynctty_receive() and ppp_sync_receive(), call tty_unthrottle()
which may sleep. Fix the comments claiming otherwise.

Impact: documentation
Signed-off-by: Tilman Schmidt <tilman@imap.cc>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Tilman Schmidt authored and David S. Miller committed Oct 7, 2009
1 parent a549952 commit 92d326f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
5 changes: 1 addition & 4 deletions drivers/net/ppp_async.c
Original file line number Diff line number Diff line change
Expand Up @@ -337,10 +337,7 @@ ppp_asynctty_poll(struct tty_struct *tty, struct file *file, poll_table *wait)
return 0;
}

/*
* This can now be called from hard interrupt level as well
* as soft interrupt level or mainline.
*/
/* May sleep, don't call from interrupt level or with interrupts disabled */
static void
ppp_asynctty_receive(struct tty_struct *tty, const unsigned char *buf,
char *cflags, int count)
Expand Down
5 changes: 1 addition & 4 deletions drivers/net/ppp_synctty.c
Original file line number Diff line number Diff line change
Expand Up @@ -378,10 +378,7 @@ ppp_sync_poll(struct tty_struct *tty, struct file *file, poll_table *wait)
return 0;
}

/*
* This can now be called from hard interrupt level as well
* as soft interrupt level or mainline.
*/
/* May sleep, don't call from interrupt level or with interrupts disabled */
static void
ppp_sync_receive(struct tty_struct *tty, const unsigned char *buf,
char *cflags, int count)
Expand Down

0 comments on commit 92d326f

Please sign in to comment.