Skip to content

Commit

Permalink
zram: return zram device_id from zram_add()
Browse files Browse the repository at this point in the history
This patch prepares zram to enable on-demand device creation.
zram_add() performs automatic device_id assignment and returns
new device id (>= 0) or error code (< 0).

Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Sergey Senozhatsky authored and Linus Torvalds committed Jun 26, 2015
1 parent b31177f commit 92ff152
Showing 1 changed file with 14 additions and 9 deletions.
23 changes: 14 additions & 9 deletions drivers/block/zram/zram_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -1153,20 +1153,24 @@ static struct attribute_group zram_disk_attr_group = {
.attrs = zram_disk_attrs,
};

static int zram_add(int device_id)
/*
* Allocate and initialize new zram device. the function returns
* '>= 0' device_id upon success, and negative value otherwise.
*/
static int zram_add(void)
{
struct zram *zram;
struct request_queue *queue;
int ret;
int ret, device_id;

zram = kzalloc(sizeof(struct zram), GFP_KERNEL);
if (!zram)
return -ENOMEM;

ret = idr_alloc(&zram_index_idr, zram, device_id,
device_id + 1, GFP_KERNEL);
ret = idr_alloc(&zram_index_idr, zram, 0, 0, GFP_KERNEL);
if (ret < 0)
goto out_free_dev;
device_id = ret;

init_rwsem(&zram->init_lock);

Expand Down Expand Up @@ -1240,7 +1244,7 @@ static int zram_add(int device_id)
zram->max_comp_streams = 1;

pr_info("Added device: %s\n", zram->disk->disk_name);
return 0;
return device_id;

out_free_disk:
del_gendisk(zram->disk);
Expand Down Expand Up @@ -1287,18 +1291,19 @@ static void destroy_devices(void)

static int __init zram_init(void)
{
int ret, dev_id;
int ret;

zram_major = register_blkdev(0, "zram");
if (zram_major <= 0) {
pr_warn("Unable to get major number\n");
return -EBUSY;
}

for (dev_id = 0; dev_id < num_devices; dev_id++) {
ret = zram_add(dev_id);
if (ret != 0)
while (num_devices != 0) {
ret = zram_add();
if (ret < 0)
goto out_error;
num_devices--;
}

return 0;
Expand Down

0 comments on commit 92ff152

Please sign in to comment.