Skip to content

Commit

Permalink
ipwireless: Do not return value from sending funcs
Browse files Browse the repository at this point in the history
ipwireless: Do not return value from sending funcs

Do not return value from do_send_fragment and do_send_packet, it's not used.
The packet size checks are not useful too:

* zero length packet will never be sent, caller always passes packet_header
  size which is either 1 or 3
* MTU check is done in caller, no need to repeat

Signed-off-by: David Sterba <dsterba@suse.cz>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
David Sterba authored and Linus Torvalds committed Jul 28, 2008
1 parent d54c275 commit 93110f6
Showing 1 changed file with 3 additions and 12 deletions.
15 changes: 3 additions & 12 deletions drivers/char/pcmcia/ipwireless/hardware.c
Original file line number Diff line number Diff line change
Expand Up @@ -400,19 +400,14 @@ static void swap_packet_bitfield_from_le(unsigned char *data)
#endif
}

static int do_send_fragment(struct ipw_hardware *hw, unsigned char *data,
static void do_send_fragment(struct ipw_hardware *hw, unsigned char *data,
unsigned length)
{
unsigned i;
unsigned long flags;

start_timing();

if (length == 0)
return 0;

if (length > hw->ll_mtu)
return -1;
BUG_ON(length > hw->ll_mtu);

if (ipwireless_debug)
dump_data_bytes("send", data, length);
Expand Down Expand Up @@ -458,11 +453,9 @@ static int do_send_fragment(struct ipw_hardware *hw, unsigned char *data,
spin_unlock_irqrestore(&hw->lock, flags);

end_write_timing(length);

return 0;
}

static int do_send_packet(struct ipw_hardware *hw, struct ipw_tx_packet *packet)
static void do_send_packet(struct ipw_hardware *hw, struct ipw_tx_packet *packet)
{
unsigned short fragment_data_len;
unsigned short data_left = packet->length - packet->offset;
Expand Down Expand Up @@ -522,8 +515,6 @@ static int do_send_packet(struct ipw_hardware *hw, struct ipw_tx_packet *packet)
packet->length);
kfree(packet);
}

return 0;
}

static void ipw_setup_hardware(struct ipw_hardware *hw)
Expand Down

0 comments on commit 93110f6

Please sign in to comment.