Skip to content

Commit

Permalink
firmware loader: don't export cache_firmware and uncache_firmware
Browse files Browse the repository at this point in the history
Looks no driver has the explict requirement for the two exported
API, just don't export them anymore.

Signed-off-by: Ming Lei <ming.lei@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Ming Lei authored and Greg Kroah-Hartman committed Jun 6, 2013
1 parent 96b2c0f commit 93232e4
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 15 deletions.
6 changes: 2 additions & 4 deletions drivers/base/firmware_class.c
Original file line number Diff line number Diff line change
Expand Up @@ -1244,7 +1244,7 @@ EXPORT_SYMBOL(request_firmware_nowait);
* Return !0 otherwise
*
*/
int cache_firmware(const char *fw_name)
static int cache_firmware(const char *fw_name)
{
int ret;
const struct firmware *fw;
Expand All @@ -1259,7 +1259,6 @@ int cache_firmware(const char *fw_name)

return ret;
}
EXPORT_SYMBOL_GPL(cache_firmware);

/**
* uncache_firmware - remove one cached firmware image
Expand All @@ -1272,7 +1271,7 @@ EXPORT_SYMBOL_GPL(cache_firmware);
* Return !0 otherwise
*
*/
int uncache_firmware(const char *fw_name)
static int uncache_firmware(const char *fw_name)
{
struct firmware_buf *buf;
struct firmware fw;
Expand All @@ -1290,7 +1289,6 @@ int uncache_firmware(const char *fw_name)

return -EINVAL;
}
EXPORT_SYMBOL_GPL(uncache_firmware);

#ifdef CONFIG_PM_SLEEP
static ASYNC_DOMAIN_EXCLUSIVE(fw_cache_domain);
Expand Down
11 changes: 0 additions & 11 deletions include/linux/firmware.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,6 @@ int request_firmware_nowait(
void (*cont)(const struct firmware *fw, void *context));

void release_firmware(const struct firmware *fw);
int cache_firmware(const char *name);
int uncache_firmware(const char *name);
#else
static inline int request_firmware(const struct firmware **fw,
const char *name,
Expand All @@ -68,15 +66,6 @@ static inline void release_firmware(const struct firmware *fw)
{
}

static inline int cache_firmware(const char *name)
{
return -ENOENT;
}

static inline int uncache_firmware(const char *name)
{
return -EINVAL;
}
#endif

#endif

0 comments on commit 93232e4

Please sign in to comment.