Skip to content

Commit

Permalink
x86: fixes for lookup_address args
Browse files Browse the repository at this point in the history
Signedness mismatches in level argument.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Harvey Harrison authored and Ingo Molnar committed Feb 1, 2008
1 parent 4a14851 commit 93809be
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
2 changes: 1 addition & 1 deletion arch/x86/kernel/efi_64.c
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ static void __init early_mapping_set_exec(unsigned long start,
int executable)
{
pte_t *kpte;
int level;
unsigned int level;

while (start < end) {
kpte = lookup_address((unsigned long)__va(start), &level);
Expand Down
2 changes: 1 addition & 1 deletion arch/x86/mm/fault.c
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ static void show_fault_oops(struct pt_regs *regs, unsigned long error_code,

#ifdef CONFIG_X86_PAE
if (error_code & PF_INSTR) {
int level;
unsigned int level;
pte_t *pte = lookup_address(address, &level);

if (pte && pte_present(*pte) && !pte_exec(*pte))
Expand Down
3 changes: 2 additions & 1 deletion arch/x86/mm/ioremap.c
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,8 @@ static int ioremap_change_attr(unsigned long paddr, unsigned long size,
{
unsigned long vaddr = (unsigned long)__va(paddr);
unsigned long nrpages = size >> PAGE_SHIFT;
int err, level;
unsigned int level;
int err;

/* No change for pages after the last mapping */
if ((paddr + size - 1) >= (max_pfn_mapped << PAGE_SHIFT))
Expand Down
4 changes: 2 additions & 2 deletions arch/x86/mm/pageattr-test.c
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ static __init int print_split(struct split_state *s)
s->max_exec = 0;
for (i = 0; i < max_pfn_mapped; ) {
unsigned long addr = (unsigned long)__va(i << PAGE_SHIFT);
int level;
unsigned int level;
pte_t *pte;

pte = lookup_address(addr, &level);
Expand Down Expand Up @@ -106,7 +106,7 @@ static __init int exercise_pageattr(void)
unsigned long *bm;
pte_t *pte, pte0;
int failed = 0;
int level;
unsigned int level;
int i, k;
int err;

Expand Down

0 comments on commit 93809be

Please sign in to comment.