Skip to content

Commit

Permalink
[ARM] msm: smd: Force the half_channel struct aligmnent to 4
Browse files Browse the repository at this point in the history
Forcing the alignment prevents gcc from generating byte reads for word
member variables. Lack of this caused issues when the app processor
modified struct members and the modem saw a partial word write.

Signed-off-by: Dima Zavin <dima@android.com>
Signed-off-by: Daniel Walker <dwalker@codeaurora.org>
  • Loading branch information
Dima Zavin authored and Daniel Walker committed May 12, 2010
1 parent b42dc44 commit 93873bc
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/arm/mach-msm/smd_private.h
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ struct smd_half_channel {
unsigned char fUNUSED;
unsigned tail;
unsigned head;
} __attribute__((packed));
} __attribute__(( aligned(4), packed ));

struct smd_shared_v1 {
struct smd_half_channel ch0;
Expand Down

0 comments on commit 93873bc

Please sign in to comment.