Skip to content

Commit

Permalink
isdn: Cleanup Sections in PCMCIA driver sedlbauer
Browse files Browse the repository at this point in the history
Compiling this driver gave a section mismatch,
so I reviewed the init/exit paths of the driver
and made the correct changes.

WARNING: drivers/isdn/hisax/built-in.o(.text+0x558d6): Section mismatch
in reference from the function sedlbauer_config() to the function
.devinit.text:hisax_init_pcmcia()
The function sedlbauer_config() references
the function __devinit hisax_init_pcmcia().
This is often because sedlbauer_config lacks a __devinit
annotation or the annotation of hisax_init_pcmcia is wrong.

Signed-off-by: Henrik Kretzschmar <henne@nachtwindheim.de>
Acked-by: Karsten Keil <keil@b1-systems.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Henne authored and David S. Miller committed Mar 25, 2010
1 parent bcbe536 commit 93b39a0
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/isdn/hisax/sedlbauer_cs.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ module_param(protocol, int, 0);
event handler.
*/

static int sedlbauer_config(struct pcmcia_device *link);
static int sedlbauer_config(struct pcmcia_device *link) __devinit ;
static void sedlbauer_release(struct pcmcia_device *link);

/*
Expand All @@ -85,7 +85,7 @@ static void sedlbauer_release(struct pcmcia_device *link);
needed to manage one actual PCMCIA card.
*/

static void sedlbauer_detach(struct pcmcia_device *p_dev);
static void sedlbauer_detach(struct pcmcia_device *p_dev) __devexit;

/*
You'll also need to prototype all the functions that will actually
Expand Down Expand Up @@ -129,7 +129,7 @@ typedef struct local_info_t {
======================================================================*/

static int sedlbauer_probe(struct pcmcia_device *link)
static int __devinit sedlbauer_probe(struct pcmcia_device *link)
{
local_info_t *local;

Expand Down Expand Up @@ -177,7 +177,7 @@ static int sedlbauer_probe(struct pcmcia_device *link)
======================================================================*/

static void sedlbauer_detach(struct pcmcia_device *link)
static void __devexit sedlbauer_detach(struct pcmcia_device *link)
{
dev_dbg(&link->dev, "sedlbauer_detach(0x%p)\n", link);

Expand Down Expand Up @@ -283,7 +283,7 @@ static int sedlbauer_config_check(struct pcmcia_device *p_dev,



static int sedlbauer_config(struct pcmcia_device *link)
static int __devinit sedlbauer_config(struct pcmcia_device *link)
{
local_info_t *dev = link->priv;
win_req_t *req;
Expand Down Expand Up @@ -441,7 +441,7 @@ static struct pcmcia_driver sedlbauer_driver = {
.name = "sedlbauer_cs",
},
.probe = sedlbauer_probe,
.remove = sedlbauer_detach,
.remove = __devexit_p(sedlbauer_detach),
.id_table = sedlbauer_ids,
.suspend = sedlbauer_suspend,
.resume = sedlbauer_resume,
Expand Down

0 comments on commit 93b39a0

Please sign in to comment.