Skip to content

Commit

Permalink
arm: mach-davinci: check irq2ctlr() result
Browse files Browse the repository at this point in the history
If irq2ctlr() fails return IRQ_NONE.
Also as it can fail make 'ctlr' signed.

The semantic patch that finds this problem (many false-positive results):
(http://coccinelle.lip6.fr/)

// <smpl>
@ r1 @
identifier f;
@@
int f(...) { ... }

@@
identifier r1.f;
type T;
unsigned T x;
@@

*x = f(...)
 ...
*x > 0

Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
Signed-off-by: Kevin Hilman <khilman@deeprootsystems.com>
  • Loading branch information
Kulikov Vasiliy authored and Kevin Hilman committed Sep 24, 2010
1 parent 85b8307 commit 93fe23d
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions arch/arm/mach-davinci/dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -354,10 +354,12 @@ static int irq2ctlr(int irq)
static irqreturn_t dma_irq_handler(int irq, void *data)
{
int i;
unsigned ctlr;
int ctlr;
unsigned int cnt = 0;

ctlr = irq2ctlr(irq);
if (ctlr < 0)
return IRQ_NONE;

dev_dbg(data, "dma_irq_handler\n");

Expand Down Expand Up @@ -408,10 +410,12 @@ static irqreturn_t dma_irq_handler(int irq, void *data)
static irqreturn_t dma_ccerr_handler(int irq, void *data)
{
int i;
unsigned ctlr;
int ctlr;
unsigned int cnt = 0;

ctlr = irq2ctlr(irq);
if (ctlr < 0)
return IRQ_NONE;

dev_dbg(data, "dma_ccerr_handler\n");

Expand Down

0 comments on commit 93fe23d

Please sign in to comment.