Skip to content

Commit

Permalink
audit: replace obsolete NLMSG_* with type safe nlmsg_*
Browse files Browse the repository at this point in the history
Signed-off-by: Hong Zhiguo <honkiko@gmail.com>
Acked-by: Thomas Graf <tgraf@suug.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Hong zhi guo authored and David S. Miller committed Mar 28, 2013
1 parent 573ce26 commit 9419121
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions kernel/audit.c
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
#ifdef CONFIG_SECURITY
#include <linux/security.h>
#endif
#include <linux/netlink.h>
#include <net/netlink.h>
#include <linux/freezer.h>
#include <linux/tty.h>
#include <linux/pid_namespace.h>
Expand Down Expand Up @@ -910,7 +910,7 @@ static void audit_receive_skb(struct sk_buff *skb)
{
struct nlmsghdr *nlh;
/*
* len MUST be signed for NLMSG_NEXT to be able to dec it below 0
* len MUST be signed for nlmsg_next to be able to dec it below 0
* if the nlmsg_len was not aligned
*/
int len;
Expand All @@ -919,13 +919,13 @@ static void audit_receive_skb(struct sk_buff *skb)
nlh = nlmsg_hdr(skb);
len = skb->len;

while (NLMSG_OK(nlh, len)) {
while (nlmsg_ok(nlh, len)) {
err = audit_receive_msg(skb, nlh);
/* if err or if this message says it wants a response */
if (err || (nlh->nlmsg_flags & NLM_F_ACK))
netlink_ack(skb, nlh, err);

nlh = NLMSG_NEXT(nlh, len);
nlh = nlmsg_next(nlh, len);
}
}

Expand Down Expand Up @@ -1483,7 +1483,7 @@ void audit_log_end(struct audit_buffer *ab)
audit_log_lost("rate limit exceeded");
} else {
struct nlmsghdr *nlh = nlmsg_hdr(ab->skb);
nlh->nlmsg_len = ab->skb->len - NLMSG_SPACE(0);
nlh->nlmsg_len = ab->skb->len - NLMSG_HDRLEN;

if (audit_pid) {
skb_queue_tail(&audit_skb_queue, ab->skb);
Expand Down

0 comments on commit 9419121

Please sign in to comment.