Skip to content

Commit

Permalink
MIPS: JZ4740: Fixup #include's (sparse)
Browse files Browse the repository at this point in the history
Fixes sparse warnings:

  arch/mips/jz4740/irq.c:63:6: warning: symbol 'jz4740_irq_suspend' was not declared. Should it be static?
  arch/mips/jz4740/irq.c:69:6: warning: symbol 'jz4740_irq_resume' was not declared. Should it be static?

Also, I've seen some elusive build errors on my automated build test
where JZ4740_IRQ_BASE and NR_IRQS are missing, but I can't reproduce
them manually for some reason. Anyway, mach-jz4740/irq.h should help us
avoid relying on some implicit include.

Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/8724/
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
  • Loading branch information
Brian Norris authored and Ralf Baechle committed Jan 13, 2015
1 parent 389cdc5 commit 942e22d
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions arch/mips/jz4740/irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@
#include <asm/irq_cpu.h>

#include <asm/mach-jz4740/base.h>
#include <asm/mach-jz4740/irq.h>

#include "irq.h"

static void __iomem *jz_intc_base;

Expand Down

0 comments on commit 942e22d

Please sign in to comment.