Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 130261
b: refs/heads/master
c: cd12e1f
h: refs/heads/master
i:
  130259: 61bc0e4
v: v3
  • Loading branch information
Mark Lord authored and Jeff Garzik committed Jan 26, 2009
1 parent 03da150 commit 945aa19
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 12 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: cae6edc3b5a536119374a5439d9b253cb26f05e1
refs/heads/master: cd12e1f7a2c28917c89d65c0d4a52d3919b4c125
13 changes: 2 additions & 11 deletions trunk/drivers/ata/sata_mv.c
Original file line number Diff line number Diff line change
Expand Up @@ -349,8 +349,6 @@ enum {

EDMA_HALTCOND_OFS = 0x60, /* GenIIe halt conditions */

GEN_II_NCQ_MAX_SECTORS = 256, /* max sects/io on Gen2 w/NCQ */

/* Host private flags (hp_flags) */
MV_HP_FLAG_MSI = (1 << 0),
MV_HP_ERRATA_50XXB0 = (1 << 1),
Expand Down Expand Up @@ -1093,20 +1091,12 @@ static void mv6_dev_config(struct ata_device *adev)
*
* Gen-II does not support NCQ over a port multiplier
* (no FIS-based switching).
*
* We don't have hob_nsect when doing NCQ commands on Gen-II.
* See mv_qc_prep() for more info.
*/
if (adev->flags & ATA_DFLAG_NCQ) {
if (sata_pmp_attached(adev->link->ap)) {
adev->flags &= ~ATA_DFLAG_NCQ;
ata_dev_printk(adev, KERN_INFO,
"NCQ disabled for command-based switching\n");
} else if (adev->max_sectors > GEN_II_NCQ_MAX_SECTORS) {
adev->max_sectors = GEN_II_NCQ_MAX_SECTORS;
ata_dev_printk(adev, KERN_INFO,
"max_sectors limited to %u for NCQ\n",
adev->max_sectors);
}
}
}
Expand Down Expand Up @@ -1444,7 +1434,8 @@ static void mv_qc_prep(struct ata_queued_cmd *qc)
* only 11 bytes...so we must pick and choose required
* registers based on the command. So, we drop feature and
* hob_feature for [RW] DMA commands, but they are needed for
* NCQ. NCQ will drop hob_nsect.
* NCQ. NCQ will drop hob_nsect, which is not needed there
* (nsect is used only for the tag; feat/hob_feat hold true nsect).
*/
switch (tf->command) {
case ATA_CMD_READ:
Expand Down

0 comments on commit 945aa19

Please sign in to comment.