Skip to content

Commit

Permalink
ALSA: Evaluate condition in snd_BUG_ON() in non-debugging case
Browse files Browse the repository at this point in the history
Change snd_BUG_ON() to evaluate the given condition, at least, in syntax
for avoiding compile warnings such as unused variables.  The compiler
should optimize out the condition evaluation in the real code, though.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Takashi Iwai committed Nov 7, 2008
1 parent 63cf123 commit 945eed0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions include/sound/core.h
Original file line number Diff line number Diff line change
Expand Up @@ -390,11 +390,11 @@ void snd_verbose_printd(const char *file, int line, const char *format, ...)

#define snd_printd(fmt, args...) do { } while (0)
#define snd_BUG() do { } while (0)
static inline int __snd_bug_on(void)
static inline int __snd_bug_on(int cond)
{
return 0;
}
#define snd_BUG_ON(cond) __snd_bug_on() /* always false */
#define snd_BUG_ON(cond) __snd_bug_on(0 && (cond)) /* always false */

#endif /* CONFIG_SND_DEBUG */

Expand Down

0 comments on commit 945eed0

Please sign in to comment.