Skip to content

Commit

Permalink
[PATCH] ioremap balanced with iounmap for drivers/video/S3triofb
Browse files Browse the repository at this point in the history
ioremap must be balanced by an iounmap and failing to do so can result in a
memory leak.

Signed-off-by: Amol Lad <amol@verismonetworks.com>
Cc: "Antonino A. Daplas" <adaplas@pol.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Amol Lad authored and Linus Torvalds committed Dec 8, 2006
1 parent 57354c4 commit 945f0ee
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions drivers/video/S3triofb.c
Original file line number Diff line number Diff line change
Expand Up @@ -535,8 +535,11 @@ static void __init s3triofb_of_init(struct device_node *dp)
#endif

fb_info.flags = FBINFO_FLAG_DEFAULT;
if (register_framebuffer(&fb_info) < 0)
return;
if (register_framebuffer(&fb_info) < 0) {
iounmap(fb_info.screen_base);
fb_info.screen_base = NULL;
return;
}

printk("fb%d: S3 Trio frame buffer device on %s\n",
fb_info.node, dp->full_name);
Expand Down

0 comments on commit 945f0ee

Please sign in to comment.