Skip to content

Commit

Permalink
perf report: Change default callchain parameters
Browse files Browse the repository at this point in the history
The default callchain parameters are set to use the flat mode and never
filter any overhead threshold of backtrace.

But flat mode is boring compared to graph mode.
Also the number of callchains may be very high if none is
filtered.

Let's change this to set the graph view and a minimum overhead of 0.5%
as default parameters.

Reported-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Anton Blanchard <anton@samba.org>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
LKML-Reference: <1246772361-9960-3-git-send-email-fweisbec@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Frederic Weisbecker authored and Ingo Molnar committed Jul 5, 2009
1 parent be90388 commit 94a8eb0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tools/perf/builtin-report.c
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,10 @@ static regex_t parent_regex;

static int exclude_other = 1;

static char callchain_default_opt[] = "flat,0";
static char callchain_default_opt[] = "graph,0.5";
static int callchain;
static enum chain_mode callchain_mode;
static double callchain_min_percent = 0.0;
static double callchain_min_percent = 0.5;

static u64 sample_type;

Expand Down

0 comments on commit 94a8eb0

Please sign in to comment.