Skip to content

Commit

Permalink
V4L/DVB (10259): pvrusb2: Code module name directly in printk
Browse files Browse the repository at this point in the history
The name of the pvrusb2 module is not likely to ever change, and there
are plenty of other places where the name is directly coded, so there
is little utility in using a macro to infer the module name here.  In
addition, using that macro complicates other uses of the driver
involving older kernels where this macro works differently.  Yes I
know for many places we don't have to worry about that.  But my
alternative is that I have to build special logic in the pvrusb2
standalone driver to special-case what is otherwise costmetic and that
is just plain nuts for something as trivial as this, especially since
this change does not at all have any compile time or run time impact
on the driver.  I'm just removing a nicety that didn't have a lot of
value here to begin with.

Signed-off-by: Mike Isely <isely@pobox.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Mike Isely authored and Mauro Carvalho Chehab committed Mar 30, 2009
1 parent 2cc3b6b commit 94b5ff9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/media/video/pvrusb2/pvrusb2-main.c
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,10 @@ static int __init pvr_init(void)
ret = usb_register(&pvr_driver);

if (ret == 0)
printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_VERSION ":"
printk(KERN_INFO "pvrusb2: " DRIVER_VERSION ":"
DRIVER_DESC "\n");
if (pvrusb2_debug)
printk(KERN_INFO KBUILD_MODNAME ": Debug mask is %d (0x%x)\n",
printk(KERN_INFO "pvrusb2: Debug mask is %d (0x%x)\n",
pvrusb2_debug,pvrusb2_debug);

pvr2_trace(PVR2_TRACE_INIT,"pvr_init complete");
Expand Down

0 comments on commit 94b5ff9

Please sign in to comment.