Skip to content

Commit

Permalink
V4L/DVB (7758): ivtv: fix oops when itv->speed == 0 and VIDEO_CMD_PLA…
Browse files Browse the repository at this point in the history
…Y is called

Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
  • Loading branch information
Hans Verkuil authored and Mauro Carvalho Chehab committed Apr 29, 2008
1 parent 22f23fc commit 94dee76
Showing 1 changed file with 21 additions and 10 deletions.
31 changes: 21 additions & 10 deletions drivers/media/video/ivtv/ivtv-ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -243,20 +243,31 @@ static int ivtv_validate_speed(int cur_speed, int new_speed)
int fact = new_speed < 0 ? -1 : 1;
int s;

if (new_speed < 0) new_speed = -new_speed;
if (cur_speed < 0) cur_speed = -cur_speed;
if (cur_speed == 0)
cur_speed = 1000;
if (new_speed < 0)
new_speed = -new_speed;
if (cur_speed < 0)
cur_speed = -cur_speed;

if (cur_speed <= new_speed) {
if (new_speed > 1500) return fact * 2000;
if (new_speed > 1000) return fact * 1500;
if (new_speed > 1500)
return fact * 2000;
if (new_speed > 1000)
return fact * 1500;
}
else {
if (new_speed >= 2000) return fact * 2000;
if (new_speed >= 1500) return fact * 1500;
if (new_speed >= 1000) return fact * 1000;
}
if (new_speed == 0) return 1000;
if (new_speed == 1 || new_speed == 1000) return fact * new_speed;
if (new_speed >= 2000)
return fact * 2000;
if (new_speed >= 1500)
return fact * 1500;
if (new_speed >= 1000)
return fact * 1000;
}
if (new_speed == 0)
return 1000;
if (new_speed == 1 || new_speed == 1000)
return fact * new_speed;

s = new_speed;
new_speed = 1000 / new_speed;
Expand Down

0 comments on commit 94dee76

Please sign in to comment.