Skip to content

Commit

Permalink
IB/qib: Completion queue callback needs to be single threaded
Browse files Browse the repository at this point in the history
Workqueues aren't exactly equivalent to tasklets since the callback
function may be called from multiple CPUs before the callback returns.
This causes completion notification callbacks to have MT bugs since
they weren't expecting this behavior. The fix is to use a single
threaded work queue.

Signed-off-by: Ralph Campbell <ralph.campbell@qlogic.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
  • Loading branch information
Ralph Campbell authored and Roland Dreier committed Jul 6, 2010
1 parent 7c7a416 commit 950aff5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/infiniband/hw/qib/qib_init.c
Original file line number Diff line number Diff line change
Expand Up @@ -1059,7 +1059,7 @@ static int __init qlogic_ib_init(void)
goto bail_dev;
}

qib_cq_wq = create_workqueue("qib_cq");
qib_cq_wq = create_singlethread_workqueue("qib_cq");
if (!qib_cq_wq) {
ret = -ENOMEM;
goto bail_wq;
Expand Down

0 comments on commit 950aff5

Please sign in to comment.