Skip to content

Commit

Permalink
writeback: remove the always false bdi_cap_writeback_dirty() test
Browse files Browse the repository at this point in the history
This is dead code because no bdi flush thread will be started for
!bdi_cap_writeback_dirty bdi.

Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Christoph Hellwig <hch@infradead.org>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
  • Loading branch information
Wu Fengguang authored and Jens Axboe committed Dec 3, 2009
1 parent bf7ec5b commit 951c30d
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions fs/fs-writeback.c
Original file line number Diff line number Diff line change
Expand Up @@ -614,7 +614,6 @@ static void writeback_inodes_wb(struct bdi_writeback *wb,
struct writeback_control *wbc)
{
struct super_block *sb = wbc->sb, *pin_sb = NULL;
const int is_blkdev_sb = sb_is_blkdev_sb(sb);
const unsigned long start = jiffies; /* livelock avoidance */

spin_lock(&inode_lock);
Expand All @@ -635,23 +634,6 @@ static void writeback_inodes_wb(struct bdi_writeback *wb,
continue;
}

if (!bdi_cap_writeback_dirty(wb->bdi)) {
redirty_tail(inode);
if (is_blkdev_sb) {
/*
* Dirty memory-backed blockdev: the ramdisk
* driver does this. Skip just this inode
*/
continue;
}
/*
* Dirty memory-backed inode against a filesystem other
* than the kernel-internal bdev filesystem. Skip the
* entire superblock.
*/
break;
}

if (inode->i_state & (I_NEW | I_WILL_FREE)) {
requeue_io(inode);
continue;
Expand Down

0 comments on commit 951c30d

Please sign in to comment.