Skip to content

Commit

Permalink
[PATCH] bogus symbol used in arch/um/os-Linux/elf_aux.c
Browse files Browse the repository at this point in the history
elf_aux is userland code; it uses symbol (ELF_CLASS) that doesn't exist in
userland headers; pulled into kernel-offsets.h, switched elf_aux to using it.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
viro@ZenIV.linux.org.uk authored and Linus Torvalds committed Sep 8, 2005
1 parent 8412205 commit 9560826
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 1 deletion.
1 change: 1 addition & 0 deletions arch/um/include/common-offsets.h
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ DEFINE_STR(UM_KERN_WARNING, KERN_WARNING);
DEFINE_STR(UM_KERN_NOTICE, KERN_NOTICE);
DEFINE_STR(UM_KERN_INFO, KERN_INFO);
DEFINE_STR(UM_KERN_DEBUG, KERN_DEBUG);
DEFINE(HOST_ELF_CLASS, ELF_CLASS);
3 changes: 3 additions & 0 deletions arch/um/os-Linux/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ obj-y = aio.o elf_aux.o file.o process.o signal.o start_up.o time.o tt.o \
USER_OBJS := aio.o elf_aux.o file.o process.o signal.o start_up.o time.o tt.o \
tty.o

elf_aux.o: $(ARCH_DIR)/kernel-offsets.h
CFLAGS_elf_aux.o += -I$(objtree)/arch/um

CFLAGS_user_syms.o += -DSUBARCH_$(SUBARCH)

HAVE_AIO_ABI := $(shell [ -r /usr/include/linux/aio_abi.h ] && \
Expand Down
3 changes: 2 additions & 1 deletion arch/um/os-Linux/elf_aux.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,9 @@
#include "init.h"
#include "elf_user.h"
#include "mem_user.h"
#include <kernel-offsets.h>

#if ELF_CLASS == ELFCLASS32
#if HOST_ELF_CLASS == ELFCLASS32
typedef Elf32_auxv_t elf_auxv_t;
#else
typedef Elf64_auxv_t elf_auxv_t;
Expand Down
1 change: 1 addition & 0 deletions arch/um/sys-i386/kernel-offsets.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#include <linux/stddef.h>
#include <linux/sched.h>
#include <linux/time.h>
#include <linux/elf.h>
#include <asm/page.h>

#define DEFINE(sym, val) \
Expand Down
1 change: 1 addition & 0 deletions arch/um/sys-x86_64/kernel-offsets.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#include <linux/stddef.h>
#include <linux/sched.h>
#include <linux/time.h>
#include <linux/elf.h>
#include <asm/page.h>

#define DEFINE(sym, val) \
Expand Down

0 comments on commit 9560826

Please sign in to comment.