Skip to content

Commit

Permalink
drivers/net/niu.c: adjust array index
Browse files Browse the repository at this point in the history
Convert array index from the loop bound to the loop index.

A simplified version of the semantic patch that fixes this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e1,e2,ar;
@@

for(e1 = 0; e1 < e2; e1++) { <...
  ar[
- e2
+ e1
  ]
  ...> }
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Julia Lawall authored and David S. Miller committed Aug 1, 2011
1 parent a1889c0 commit 956837f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/niu.c
Original file line number Diff line number Diff line change
Expand Up @@ -9201,7 +9201,7 @@ static int __devinit niu_ldg_init(struct niu *np)

first_chan = 0;
for (i = 0; i < port; i++)
first_chan += parent->rxchan_per_port[port];
first_chan += parent->rxchan_per_port[i];
num_chan = parent->rxchan_per_port[port];

for (i = first_chan; i < (first_chan + num_chan); i++) {
Expand All @@ -9217,7 +9217,7 @@ static int __devinit niu_ldg_init(struct niu *np)

first_chan = 0;
for (i = 0; i < port; i++)
first_chan += parent->txchan_per_port[port];
first_chan += parent->txchan_per_port[i];
num_chan = parent->txchan_per_port[port];
for (i = first_chan; i < (first_chan + num_chan); i++) {
err = niu_ldg_assign_ldn(np, parent,
Expand Down

0 comments on commit 956837f

Please sign in to comment.