Skip to content

Commit

Permalink
mfd: Define all twl-regulator feature flags in one place
Browse files Browse the repository at this point in the history
twl-regulator has a collection of feature flags, some defined
in twl-core.c and  one defined in i2c/twl.h.
This is confusing for anyone adding a new feature flag.

So collect them together and place them in twl.h immediately
after the structure in which they are initially set.

Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
  • Loading branch information
NeilBrown authored and Samuel Ortiz committed May 20, 2012
1 parent cd4209c commit 9577e8c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
7 changes: 0 additions & 7 deletions drivers/mfd/twl-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -224,13 +224,6 @@
#define HIGH_PERF_SQ (1 << 3)
#define CK32K_LOWPWR_EN (1 << 7)


/* chip-specific feature flags, for i2c_device_id.driver_data */
#define TWL4030_VAUX2 BIT(0) /* pre-5030 voltage ranges */
#define TPS_SUBSET BIT(1) /* tps659[23]0 have fewer LDOs */
#define TWL5031 BIT(2) /* twl5031 has different registers */
#define TWL6030_CLASS BIT(3) /* TWL6030 class */

/*----------------------------------------------------------------------*/

/* is driver active, bound to a chip? */
Expand Down
8 changes: 6 additions & 2 deletions include/linux/i2c/twl.h
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,6 @@ static inline int twl_class_is_ ##class(void) \
TWL_CLASS_IS(4030, TWL4030_CLASS_ID)
TWL_CLASS_IS(6030, TWL6030_CLASS_ID)

#define TWL6025_SUBCLASS BIT(4) /* TWL6025 has changed registers */

/*
* Read and write single 8-bit registers
*/
Expand Down Expand Up @@ -746,6 +744,12 @@ struct twl_regulator_driver_data {
void *data;
unsigned long features;
};
/* chip-specific feature flags, for twl_regulator_driver_data.features */
#define TWL4030_VAUX2 BIT(0) /* pre-5030 voltage ranges */
#define TPS_SUBSET BIT(1) /* tps659[23]0 have fewer LDOs */
#define TWL5031 BIT(2) /* twl5031 has different registers */
#define TWL6030_CLASS BIT(3) /* TWL6030 class */
#define TWL6025_SUBCLASS BIT(4) /* TWL6025 has changed registers */

/*----------------------------------------------------------------------*/

Expand Down

0 comments on commit 9577e8c

Please sign in to comment.