Skip to content

Commit

Permalink
iommu/tegra: remove invalid reference to list iterator variable
Browse files Browse the repository at this point in the history
If list_for_each_entry, etc complete a traversal of the
list, the iterator variable ends up pointing to an address
at an offset from the list head, and not a meaningful
structure.  Thus this value should not be used after the end
of the iterator.  Replace c->dev by dev, which is the value
that c->dev has been compared to.

This problem was found using Coccinelle (http://coccinelle.lip6.fr/).

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
Acked-by: Hiroshi DOYU <hdoyu@nvidia.com>
Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
  • Loading branch information
Julia Lawall authored and Joerg Roedel committed Aug 3, 2012
1 parent 0d7614f commit 9579a97
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/iommu/tegra-smmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -799,7 +799,7 @@ static void smmu_iommu_detach_dev(struct iommu_domain *domain,
goto out;
}
}
dev_err(smmu->dev, "Couldn't find %s\n", dev_name(c->dev));
dev_err(smmu->dev, "Couldn't find %s\n", dev_name(dev));
out:
spin_unlock(&as->client_lock);
}
Expand Down

0 comments on commit 9579a97

Please sign in to comment.