Skip to content

Commit

Permalink
staging: Remove unnecessary semicolons when switch (foo) {...};
Browse files Browse the repository at this point in the history
Done via perl script:

$ cat remove_semi_switch.pl
my $match_balanced_parentheses = qr/(\((?:[^\(\)]++|(?-1))*\))/;
my $match_balanced_braces      = qr/(\{(?:[^\{\}]++|(?-1))*\})/;

foreach my $file (@ARGV) {
    my $f;
    my $text;
    my $oldtext;

    next if ((-d $file));

    open($f, '<', $file)
	or die "$P: Can't open $file for read\n";
    $oldtext = do { local($/) ; <$f> };
    close($f);

    next if ($oldtext eq "");

    $text = $oldtext;

    my $count = 0;
    do {
	$count = 0;
	$count += $text =~ s@\b(switch\s*${match_balanced_parentheses}\s*)${match_balanced_braces}\s*;@"$1$3"@egx;
    } while ($count > 0);

    if ($text ne $oldtext) {
	my $newfile = $file;

	open($f, '>', $newfile)
	    or die "$P: Can't open $newfile for write\n";
	print $f $text;
	close($f);
    }
}

$

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Joe Perches authored and Greg Kroah-Hartman committed Apr 25, 2011
1 parent 273f4be commit 95cd17c
Show file tree
Hide file tree
Showing 16 changed files with 26 additions and 26 deletions.
6 changes: 3 additions & 3 deletions drivers/staging/ath6kl/os/linux/ar6000_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -4230,7 +4230,7 @@ ar6000_connect_event(struct ar6_softc *ar, u16 channel, u8 *bssid,
default:
A_PRINTF("AUTH: Unknown\n");
break;
};
}
switch (listenInterval&0xFF) {
case WPA_PSK_AUTH:
A_PRINTF("KeyMgmt: WPA-PSK\n");
Expand All @@ -4241,7 +4241,7 @@ ar6000_connect_event(struct ar6_softc *ar, u16 channel, u8 *bssid,
default:
A_PRINTF("KeyMgmt: NONE\n");
break;
};
}
switch (beaconInterval) {
case AES_CRYPT:
A_PRINTF("Cipher: AES\n");
Expand All @@ -4260,7 +4260,7 @@ ar6000_connect_event(struct ar6_softc *ar, u16 channel, u8 *bssid,
default:
A_PRINTF("Cipher: NONE\n");
break;
};
}

add_new_sta(ar, bssid, channel /*aid*/,
assocInfo /* WPA IE */, assocRespLen /* IE len */,
Expand Down
4 changes: 2 additions & 2 deletions drivers/staging/comedi/drivers/adl_pci9118.c
Original file line number Diff line number Diff line change
Expand Up @@ -1417,7 +1417,7 @@ static int pci9118_ai_docmd_sampl(struct comedi_device *dev,
comedi_error(dev,
"pci9118_ai_docmd_sampl() mode number bug!\n");
return -EIO;
};
}

devpriv->int_ai_func = interrupt_pci9118_ai_onesample;
/* transfer function */
Expand Down Expand Up @@ -1496,7 +1496,7 @@ static int pci9118_ai_docmd_dma(struct comedi_device *dev,
default:
comedi_error(dev, "pci9118_ai_docmd_dma() mode number bug!\n");
return -EIO;
};
}

if (devpriv->ai12_startstop) {
pci9118_exttrg_add(dev, EXTTRG_AI);
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/cb_pcidda.c
Original file line number Diff line number Diff line change
Expand Up @@ -650,7 +650,7 @@ static int cb_pcidda_ao_winsn(struct comedi_device *dev,
case 5:
command |= UNIP | RANGE2V5;
break;
};
}

/* output channel specification */
command |= channel << 2;
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/cb_pcimdas.c
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ static int cb_pcimdas_attach(struct comedi_device *dev,
default:
printk("THIS CARD IS UNSUPPORTED.\n"
"PLEASE REPORT USAGE TO <mocelet@sucs.org>\n");
};
}

if (comedi_pci_enable(pcidev, "cb_pcimdas")) {
printk(" Failed to enable PCI device and request regions\n");
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/ni_660x.c
Original file line number Diff line number Diff line change
Expand Up @@ -1418,7 +1418,7 @@ static int ni_660x_dio_insn_config(struct comedi_device *dev,
default:
return -EINVAL;
break;
};
}
return 0;
}

Expand Down
6 changes: 3 additions & 3 deletions drivers/staging/comedi/drivers/ni_mio_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -1627,7 +1627,7 @@ static int ni_ai_setup_MITE_dma(struct comedi_device *dev)
default:
mite_prep_dma(devpriv->ai_mite_chan, 16, 16);
break;
};
}
/*start the MITE */
mite_dma_arm(devpriv->ai_mite_chan);
spin_unlock_irqrestore(&devpriv->mite_channel_lock, flags);
Expand Down Expand Up @@ -2156,7 +2156,7 @@ static unsigned ni_min_ai_scan_period_ns(struct comedi_device *dev,
default:
/* multiplexed inputs */
break;
};
}
return boardtype.ai_speed * num_channels;
}

Expand Down Expand Up @@ -5173,7 +5173,7 @@ static void GPCT_Reset(struct comedi_device *dev, int chan)
devpriv->stc_writew(dev, devpriv->an_trig_etc_reg,
Analog_Trigger_Etc_Register);
break;
};
}

devpriv->gpct_mode[chan] = 0;
devpriv->gpct_input_select[chan] = 0;
Expand Down
6 changes: 3 additions & 3 deletions drivers/staging/comedi/drivers/ni_tio.c
Original file line number Diff line number Diff line change
Expand Up @@ -1181,7 +1181,7 @@ static int ni_660x_set_second_gate(struct ni_gpct *counter,
break;
return -EINVAL;
break;
};
}
counter_dev->regs[second_gate_reg] |= Gi_Second_Gate_Mode_Bit;
counter_dev->regs[second_gate_reg] &= ~Gi_Second_Gate_Select_Mask;
counter_dev->regs[second_gate_reg] |=
Expand Down Expand Up @@ -1209,7 +1209,7 @@ static int ni_m_series_set_second_gate(struct ni_gpct *counter,
ni_m_series_second_gate_select =
selected_second_gate & selected_second_gate_mask;
break;
};
}
counter_dev->regs[second_gate_reg] |= Gi_Second_Gate_Mode_Bit;
counter_dev->regs[second_gate_reg] &= ~Gi_Second_Gate_Select_Mask;
counter_dev->regs[second_gate_reg] |=
Expand Down Expand Up @@ -1674,7 +1674,7 @@ int ni_tio_rinsn(struct ni_gpct *counter, struct comedi_insn *insn,
counter_dev->
regs[NITIO_Gi_LoadB_Reg(counter->counter_index)];
break;
};
}
return 0;
}
EXPORT_SYMBOL_GPL(ni_tio_rinsn);
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/comedi/drivers/pcl818.c
Original file line number Diff line number Diff line change
Expand Up @@ -1662,7 +1662,7 @@ static void rtc_dropped_irq(unsigned long data)
tmp = (CMOS_READ(RTC_INTR_FLAGS) & 0xF0); /* restart */
restore_flags(flags);
break;
};
}
}

/*
Expand Down
4 changes: 2 additions & 2 deletions drivers/staging/crystalhd/crystalhd_misc.c
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ enum BC_STATUS crystalhd_pci_cfg_rd(struct crystalhd_adp *adp, uint32_t off,
rc = -EINVAL;
sts = BC_STS_INV_ARG;
BCMLOG_ERR("Invalid len:%d\n", len);
};
}

if (rc && (sts == BC_STS_SUCCESS))
sts = BC_STS_ERROR;
Expand Down Expand Up @@ -356,7 +356,7 @@ enum BC_STATUS crystalhd_pci_cfg_wr(struct crystalhd_adp *adp, uint32_t off,
rc = -EINVAL;
sts = BC_STS_INV_ARG;
BCMLOG_ERR("Invalid len:%d\n", len);
};
}

if (rc && (sts == BC_STS_SUCCESS))
sts = BC_STS_ERROR;
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/cx25821/cx25821-video.c
Original file line number Diff line number Diff line change
Expand Up @@ -1574,7 +1574,7 @@ int cx25821_set_control(struct cx25821_dev *dev,
break;
default:
/* nothing */ ;
};
}

switch (ctl->id) {
case V4L2_CID_BRIGHTNESS:
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/hv/hv_util.c
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ static void shutdown_onchannelcallback(void *context)
pr_info("Shutdown request received -"
" Invalid request\n");
break;
};
}
}

icmsghdrp->icflags = ICMSGHDRFLAG_TRANSACTION
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/iio/accel/lis3l02dq_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ static ssize_t lis3l02dq_write_frequency(struct device *dev,
default:
ret = -EINVAL;
goto error_ret_mutex;
};
}

ret = lis3l02dq_spi_write_reg_8(dev,
LIS3L02DQ_REG_CTRL_1_ADDR,
Expand Down
6 changes: 3 additions & 3 deletions drivers/staging/iio/addac/adt7316.c
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ static ssize_t adt7316_show_ad_channel(struct device *dev,
return sprintf(buf, "5 - AIN4\n");
default:
return sprintf(buf, "N/A\n");
};
}
}

static ssize_t adt7316_store_ad_channel(struct device *dev,
Expand Down Expand Up @@ -893,7 +893,7 @@ static ssize_t adt7316_show_DAC_update_mode(struct device *dev,
return sprintf(buf, "2 - auto at MSB DAC ABCD writing\n");
default: /* ADT7316_DA_EN_MODE_LDAC */
return sprintf(buf, "3 - manual\n");
};
}
}
}

Expand Down Expand Up @@ -1205,7 +1205,7 @@ static ssize_t adt7316_show_ad(struct adt7316_chip_info *chip,
return sprintf(buf, "%d\n", data);
else
break;
};
}

if (data & ADT7316_T_VALUE_SIGN) {
/* convert supplement to positive value */
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/lirc/lirc_serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,7 @@ static int set_use_inc(void *data)
default:
dprintk("Interrupt %d, port %04x obtained\n", irq, io);
break;
};
}

spin_lock_irqsave(&hardware[type].lock, flags);

Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/vt6655/wpactl.c
Original file line number Diff line number Diff line change
Expand Up @@ -832,7 +832,7 @@ else
break;
default:
pDevice->eEncryptionStatus = Ndis802_11EncryptionDisabled;
};
}

//DavidWang add for WPA_supplicant support open/share mode

Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/vt6656/wpactl.c
Original file line number Diff line number Diff line change
Expand Up @@ -831,7 +831,7 @@ static int wpa_set_associate(PSDevice pDevice,
break;
default:
pDevice->eEncryptionStatus = Ndis802_11EncryptionDisabled;
};
}

pMgmt->Roam_dbm = param->u.wpa_associate.roam_dbm;
// if ((pMgmt->Roam_dbm > 40)&&(pMgmt->Roam_dbm<80))
Expand Down

0 comments on commit 95cd17c

Please sign in to comment.