Skip to content

Commit

Permalink
spi/ath79: use gpio_request_one
Browse files Browse the repository at this point in the history
Use gpio_request_one() instead of multiple gpiolib calls.

Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
  • Loading branch information
Gabor Juhos authored and Grant Likely committed Feb 5, 2013
1 parent f1e8fc9 commit 95d7941
Showing 1 changed file with 11 additions and 11 deletions.
22 changes: 11 additions & 11 deletions drivers/spi/spi-ath79.c
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ static int ath79_spi_setup_cs(struct spi_device *spi)
{
struct ath79_spi *sp = ath79_spidev_to_sp(spi);
struct ath79_spi_controller_data *cdata;
int status;

cdata = spi->controller_data;
if (spi->chip_select && !cdata)
Expand All @@ -115,22 +116,21 @@ static int ath79_spi_setup_cs(struct spi_device *spi)
/* TODO: setup speed? */
ath79_spi_wr(sp, AR71XX_SPI_REG_CTRL, 0x43);

status = 0;
if (spi->chip_select) {
int status = 0;
unsigned long flags;

status = gpio_request(cdata->gpio, dev_name(&spi->dev));
if (status)
return status;
flags = GPIOF_DIR_OUT;
if (spi->mode & SPI_CS_HIGH)
flags |= GPIOF_INIT_HIGH;
else
flags |= GPIOF_INIT_LOW;

status = gpio_direction_output(cdata->gpio,
spi->mode & SPI_CS_HIGH);
if (status) {
gpio_free(cdata->gpio);
return status;
}
status = gpio_request_one(cdata->gpio, flags,
dev_name(&spi->dev));
}

return 0;
return status;
}

static void ath79_spi_cleanup_cs(struct spi_device *spi)
Expand Down

0 comments on commit 95d7941

Please sign in to comment.