Skip to content

Commit

Permalink
atl1e: Remove redundant definitions of ethtool operations
Browse files Browse the repository at this point in the history
These functions provide the default behaviour and do not need to be
set in struct ethtool_ops.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ben Hutchings authored and David S. Miller committed Dec 3, 2009
1 parent ac93692 commit 95fec16
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions drivers/net/atl1e/atl1e_ethtool.c
Original file line number Diff line number Diff line change
Expand Up @@ -131,11 +131,6 @@ static int atl1e_set_settings(struct net_device *netdev,
return 0;
}

static u32 atl1e_get_tx_csum(struct net_device *netdev)
{
return (netdev->features & NETIF_F_HW_CSUM) != 0;
}

static u32 atl1e_get_msglevel(struct net_device *netdev)
{
#ifdef DBG
Expand Down Expand Up @@ -393,13 +388,8 @@ static const struct ethtool_ops atl1e_ethtool_ops = {
.get_eeprom_len = atl1e_get_eeprom_len,
.get_eeprom = atl1e_get_eeprom,
.set_eeprom = atl1e_set_eeprom,
.get_tx_csum = atl1e_get_tx_csum,
.set_tx_csum = ethtool_op_set_tx_hw_csum,
.get_sg = ethtool_op_get_sg,
.set_sg = ethtool_op_set_sg,
#ifdef NETIF_F_TSO
.get_tso = ethtool_op_get_tso,
#endif
.set_tso = ethtool_op_set_tso,
};

Expand Down

0 comments on commit 95fec16

Please sign in to comment.