Skip to content

Commit

Permalink
Revert "serial: of-serial: fix up PM ops on no_console_suspend and po…
Browse files Browse the repository at this point in the history
…rt type"

This reverts commit 513e438.

It's broken :(

Cc: Jingchang Lu <jingchang.lu@freescale.com>
Cc: Joseph Lo <josephl@nvidia.com>
Cc: Peter Hurley <peter@hurleysoftware.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Greg Kroah-Hartman committed Nov 26, 2014
1 parent 6fad18f commit 962b0a8
Showing 1 changed file with 7 additions and 46 deletions.
53 changes: 7 additions & 46 deletions drivers/tty/serial/of_serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
* 2 of the License, or (at your option) any later version.
*
*/
#include <linux/console.h>
#include <linux/module.h>
#include <linux/slab.h>
#include <linux/delay.h>
Expand Down Expand Up @@ -249,48 +248,13 @@ static int of_platform_serial_remove(struct platform_device *ofdev)
}

#ifdef CONFIG_PM_SLEEP
#ifdef CONFIG_SERIAL_8250
static void of_serial_suspend_8250(struct of_serial_info *info)
{
struct uart_8250_port *port8250 = serial8250_get_port(info->line);
struct uart_port *port = &port8250->port;

serial8250_suspend_port(info->line);
if (info->clk && (!uart_console(port) || console_suspend_enabled))
clk_disable_unprepare(info->clk);
}

static void of_serial_resume_8250(struct of_serial_info *info)
{
struct uart_8250_port *port8250 = serial8250_get_port(info->line);
struct uart_port *port = &port8250->port;

if (info->clk && (!uart_console(port) || console_suspend_enabled))
clk_prepare_enable(info->clk);

serial8250_resume_port(info->line);
}
#else
static inline void of_serial_suspend_8250(struct of_serial_info *info)
{
}

static inline void of_serial_resume_8250(struct of_serial_info *info)
{
}
#endif

static int of_serial_suspend(struct device *dev)
{
struct of_serial_info *info = dev_get_drvdata(dev);

switch(info->type) {
case PORT_8250 ... PORT_MAX_8250:
of_serial_suspend_8250(info);
break;
default:
break;
}
serial8250_suspend_port(info->line);
if (info->clk)
clk_disable_unprepare(info->clk);

return 0;
}
Expand All @@ -299,13 +263,10 @@ static int of_serial_resume(struct device *dev)
{
struct of_serial_info *info = dev_get_drvdata(dev);

switch(info->type) {
case PORT_8250 ... PORT_MAX_8250:
of_serial_resume_8250(info);
break;
default:
break;
}
if (info->clk)
clk_prepare_enable(info->clk);

serial8250_resume_port(info->line);

return 0;
}
Expand Down

0 comments on commit 962b0a8

Please sign in to comment.