Skip to content

Commit

Permalink
tpm_tis: Clean up after module_param cleanup
Browse files Browse the repository at this point in the history
Commit 90ab5ee changed the
itpm module parameter from int to bool. Some other changes
need to be done to clean up after this change.

Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
  • Loading branch information
Stefan Berger authored and Rajiv Andrade committed Feb 14, 2012
1 parent 4e401fb commit 968de8e
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions drivers/char/tpm/tpm_tis.c
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,7 @@ static int probe_itpm(struct tpm_chip *chip)
0x00, 0x00, 0x00, 0xf1
};
size_t len = sizeof(cmd_getticks);
int rem_itpm = itpm;
bool rem_itpm = itpm;
u16 vendor = ioread16(chip->vendor.iobase + TPM_DID_VID(0));

/* probe only iTPMS */
Expand Down Expand Up @@ -510,7 +510,7 @@ static int tpm_tis_init(struct device *dev, resource_size_t start,
resource_size_t len, unsigned int irq)
{
u32 vendor, intfcaps, intmask;
int rc, i, irq_s, irq_e;
int rc, i, irq_s, irq_e, probe;
struct tpm_chip *chip;

if (!(chip = tpm_register_hardware(dev, &tpm_tis)))
Expand Down Expand Up @@ -540,11 +540,12 @@ static int tpm_tis_init(struct device *dev, resource_size_t start,
vendor >> 16, ioread8(chip->vendor.iobase + TPM_RID(0)));

if (!itpm) {
itpm = probe_itpm(chip);
if (itpm < 0) {
probe = probe_itpm(chip);
if (probe < 0) {
rc = -ENODEV;
goto out_err;
}
itpm = (probe == 0) ? 0 : 1;
}

if (itpm)
Expand Down

0 comments on commit 968de8e

Please sign in to comment.