Skip to content

Commit

Permalink
staging: rtl8712: remove r8712_cmd_thread()->daemonize()
Browse files Browse the repository at this point in the history
daemonize() is only needed when a user-space task does kernel_thread().

r8712_cmd_thread() is kthread_create()'ed and thus it doesn't need
the soon-to-be-deprecated daemonize(). It is the only caller of
thread_enter() which actually does the call.

Note:
	- we are going to remove the sigdelset(blocked) code from
	  allow_signal(), this means that without this patch
	  thread_enter() can't work after that. Not to mention
	  daemonize() should be deprecated.

	- as a side effect, this patch changes ->comm. Hopefully
	  this is fine, and padapter->pnetdev->name probably makes
	  more sense anyway.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Matt Fleming <matt.fleming@intel.com>
Acked-by: Tejun Heo <tj@kernel.org>
Acked-and-tested-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
  • Loading branch information
Oleg Nesterov authored and Greg Kroah-Hartman committed Aug 23, 2011
1 parent 5ae7171 commit 9693617
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/staging/rtl8712/osdep_service.h
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,6 @@ static inline unsigned char _cancel_timer_ex(struct timer_list *ptimer)

static inline void thread_enter(void *context)
{
daemonize("%s", "RTKTHREAD");
allow_signal(SIGTERM);
}

Expand Down

0 comments on commit 9693617

Please sign in to comment.