Skip to content

Commit

Permalink
cpumask fallout: Initialize irq_default_affinity earlier
Browse files Browse the repository at this point in the history
Move the initialization of irq_default_affinity to early_irq_init as
core_initcall is too late.

irq_default_affinity can be used in init_IRQ and potentially timer and
SMP init as well.  All of these happen before core_initcall.  Moving
the initialization to early_irq_init ensures that it is initialized
before it is used.

Signed-off-by: David Daney <ddaney@caviumnetworks.com>
Acked-by: Mike Travis <travis@sgi.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
David Daney authored and Linus Torvalds committed Jan 28, 2009
1 parent 1267a8d commit 97179fd
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 8 deletions.
16 changes: 16 additions & 0 deletions kernel/irq/handle.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,18 @@ void handle_bad_irq(unsigned int irq, struct irq_desc *desc)
ack_bad_irq(irq);
}

#if defined(CONFIG_SMP) && defined(CONFIG_GENERIC_HARDIRQS)
static void __init init_irq_default_affinity(void)
{
alloc_bootmem_cpumask_var(&irq_default_affinity);
cpumask_setall(irq_default_affinity);
}
#else
static void __init init_irq_default_affinity(void)
{
}
#endif

/*
* Linux has a controller-independent interrupt architecture.
* Every controller has a 'controller-template', that is used
Expand Down Expand Up @@ -134,6 +146,8 @@ int __init early_irq_init(void)
int legacy_count;
int i;

init_irq_default_affinity();

desc = irq_desc_legacy;
legacy_count = ARRAY_SIZE(irq_desc_legacy);

Expand Down Expand Up @@ -219,6 +233,8 @@ int __init early_irq_init(void)
int count;
int i;

init_irq_default_affinity();

desc = irq_desc;
count = ARRAY_SIZE(irq_desc);

Expand Down
8 changes: 0 additions & 8 deletions kernel/irq/manage.c
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,6 @@
#if defined(CONFIG_SMP) && defined(CONFIG_GENERIC_HARDIRQS)
cpumask_var_t irq_default_affinity;

static int init_irq_default_affinity(void)
{
alloc_cpumask_var(&irq_default_affinity, GFP_KERNEL);
cpumask_setall(irq_default_affinity);
return 0;
}
core_initcall(init_irq_default_affinity);

/**
* synchronize_irq - wait for pending IRQ handlers (on other CPUs)
* @irq: interrupt number to wait for
Expand Down

0 comments on commit 97179fd

Please sign in to comment.