Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 303722
b: refs/heads/master
c: 4d9b400
h: refs/heads/master
v: v3
  • Loading branch information
Greg Kroah-Hartman committed May 3, 2012
1 parent ebb6cd1 commit 971e32c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 22 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: d8789b2b90aeb53ce59ac232d2ff0d8357d53893
refs/heads/master: 4d9b4001e0cb180b8e1c9ffd7bb4372e48f207c6
26 changes: 5 additions & 21 deletions trunk/drivers/usb/serial/visor.c
Original file line number Diff line number Diff line change
Expand Up @@ -239,8 +239,6 @@ static int visor_open(struct tty_struct *tty, struct usb_serial_port *port)
{
int result = 0;

dbg("%s - port %d", __func__, port->number);

if (!port->read_urb) {
/* this is needed for some brain dead Sony devices */
dev_err(&port->dev, "Device lied about number of ports, please use a lower one.\n");
Expand All @@ -253,7 +251,7 @@ static int visor_open(struct tty_struct *tty, struct usb_serial_port *port)
goto exit;

if (port->interrupt_in_urb) {
dbg("%s - adding interrupt input for treo", __func__);
dev_dbg(&port->dev, "adding interrupt input for treo\n");
result = usb_submit_urb(port->interrupt_in_urb, GFP_KERNEL);
if (result)
dev_err(&port->dev,
Expand All @@ -269,8 +267,6 @@ static void visor_close(struct usb_serial_port *port)
{
unsigned char *transfer_buffer;

dbg("%s - port %d", __func__, port->number);

/* shutdown our urbs */
usb_serial_generic_close(port);
usb_kill_urb(port->interrupt_in_urb);
Expand Down Expand Up @@ -305,12 +301,12 @@ static void visor_read_int_callback(struct urb *urb)
case -ENOENT:
case -ESHUTDOWN:
/* this urb is terminated, clean up */
dbg("%s - urb shutting down with status: %d",
__func__, status);
dev_dbg(&port->dev, "%s - urb shutting down with status: %d\n",
__func__, status);
return;
default:
dbg("%s - nonzero urb status received: %d",
__func__, status);
dev_dbg(&port->dev, "%s - nonzero urb status received: %d\n",
__func__, status);
goto exit;
}

Expand Down Expand Up @@ -343,8 +339,6 @@ static int palm_os_3_probe(struct usb_serial *serial,
int i;
int num_ports = 0;

dbg("%s", __func__);

transfer_buffer = kmalloc(sizeof(*connection_info), GFP_KERNEL);
if (!transfer_buffer) {
dev_err(dev, "%s - kmalloc(%Zd) failed.\n", __func__,
Expand Down Expand Up @@ -440,8 +434,6 @@ static int palm_os_4_probe(struct usb_serial *serial,
unsigned char *transfer_buffer;
int retval;

dbg("%s", __func__);

transfer_buffer = kmalloc(sizeof(*connection_info), GFP_KERNEL);
if (!transfer_buffer) {
dev_err(dev, "%s - kmalloc(%Zd) failed.\n", __func__,
Expand Down Expand Up @@ -473,8 +465,6 @@ static int visor_probe(struct usb_serial *serial,
int (*startup)(struct usb_serial *serial,
const struct usb_device_id *id);

dbg("%s", __func__);

/*
* some Samsung Android phones in modem mode have the same ID
* as SPH-I500, but they are ACM devices, so dont bind to them
Expand Down Expand Up @@ -516,8 +506,6 @@ static int clie_3_5_startup(struct usb_serial *serial)
int result;
u8 *data;

dbg("%s", __func__);

data = kmalloc(1, GFP_KERNEL);
if (!data)
return -ENOMEM;
Expand Down Expand Up @@ -580,8 +568,6 @@ static int treo_attach(struct usb_serial *serial)
(serial->num_interrupt_in == 0))
return 0;

dbg("%s", __func__);

/*
* It appears that Treos and Kyoceras want to use the
* 1st bulk in endpoint to communicate with the 2nd bulk out endpoint,
Expand Down Expand Up @@ -617,8 +603,6 @@ static int clie_5_attach(struct usb_serial *serial)
unsigned int pipe;
int j;

dbg("%s", __func__);

/* TH55 registers 2 ports.
Communication in from the UX50/TH55 uses bulk_in_endpointAddress
from port 0. Communication out to the UX50/TH55 uses
Expand Down

0 comments on commit 971e32c

Please sign in to comment.