Skip to content

Commit

Permalink
oprofile: simplify add_sample()
Browse files Browse the repository at this point in the history
This patch removes add_us_sample() and simplifies add_sample(). Code
is much more readable now.

Signed-off-by: Robert Richter <robert.richter@amd.com>
  • Loading branch information
Robert Richter committed Dec 29, 2008
1 parent d45d23b commit 9741b30
Showing 1 changed file with 19 additions and 20 deletions.
39 changes: 19 additions & 20 deletions drivers/oprofile/buffer_sync.c
Original file line number Diff line number Diff line change
Expand Up @@ -392,11 +392,29 @@ static void add_sample_entry(unsigned long offset, unsigned long event)
}


static int add_us_sample(struct mm_struct *mm, struct op_sample *s)
/*
* Add a sample to the global event buffer. If possible the
* sample is converted into a persistent dentry/offset pair
* for later lookup from userspace. Return 0 on failure.
*/
static int
add_sample(struct mm_struct *mm, struct op_sample *s, int in_kernel)
{
unsigned long cookie;
off_t offset;

if (in_kernel) {
add_sample_entry(s->eip, s->event);
return 1;
}

/* add userspace sample */

if (!mm) {
atomic_inc(&oprofile_stats.sample_lost_no_mm);
return 0;
}

cookie = lookup_dcookie(mm, s->eip, &offset);

if (cookie == INVALID_COOKIE) {
Expand All @@ -415,25 +433,6 @@ static int add_us_sample(struct mm_struct *mm, struct op_sample *s)
}


/* Add a sample to the global event buffer. If possible the
* sample is converted into a persistent dentry/offset pair
* for later lookup from userspace.
*/
static int
add_sample(struct mm_struct *mm, struct op_sample *s, int in_kernel)
{
if (in_kernel) {
add_sample_entry(s->eip, s->event);
return 1;
} else if (mm) {
return add_us_sample(mm, s);
} else {
atomic_inc(&oprofile_stats.sample_lost_no_mm);
}
return 0;
}


static void release_mm(struct mm_struct *mm)
{
if (!mm)
Expand Down

0 comments on commit 9741b30

Please sign in to comment.