Skip to content

Commit

Permalink
libata: Remove excess delay in the tf_load path
Browse files Browse the repository at this point in the history
We don't need to stall and wait after loading the task file and before
issuing a command, so don't do it. This shows up on profiles and is not
needed.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Jeff Garzik <jgarzik@redhat.com>
  • Loading branch information
Alan Cox authored and Jeff Garzik committed May 15, 2010
1 parent 95cc2c7 commit 978c066
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 5 deletions.
3 changes: 0 additions & 3 deletions drivers/ata/libata-sff.c
Original file line number Diff line number Diff line change
Expand Up @@ -604,7 +604,6 @@ void ata_sff_tf_load(struct ata_port *ap, const struct ata_taskfile *tf)
if (ioaddr->ctl_addr)
iowrite8(tf->ctl, ioaddr->ctl_addr);
ap->last_ctl = tf->ctl;
ata_wait_idle(ap);
}

if (is_addr && (tf->flags & ATA_TFLAG_LBA48)) {
Expand Down Expand Up @@ -640,8 +639,6 @@ void ata_sff_tf_load(struct ata_port *ap, const struct ata_taskfile *tf)
iowrite8(tf->device, ioaddr->device_addr);
VPRINTK("device 0x%X\n", tf->device);
}

ata_wait_idle(ap);
}
EXPORT_SYMBOL_GPL(ata_sff_tf_load);

Expand Down
2 changes: 0 additions & 2 deletions drivers/ata/pata_via.c
Original file line number Diff line number Diff line change
Expand Up @@ -417,8 +417,6 @@ static void via_tf_load(struct ata_port *ap, const struct ata_taskfile *tf)
tf->lbam,
tf->lbah);
}

ata_wait_idle(ap);
}

static int via_port_start(struct ata_port *ap)
Expand Down

0 comments on commit 978c066

Please sign in to comment.