Skip to content

Commit

Permalink
MIPS: ath79: Use kmemdup rather than duplicating its implementation
Browse files Browse the repository at this point in the history
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Cc: linux-mips@linux-mips.org
Patchwork: https://patchwork.linux-mips.org/patch/3483/
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
  • Loading branch information
Thomas Meyer authored and Ralf Baechle committed May 15, 2012
1 parent 36be505 commit 97bf7a1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions arch/mips/ath79/dev-gpio-buttons.c
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,10 @@ void __init ath79_register_gpio_keys_polled(int id,
struct gpio_keys_button *p;
int err;

p = kmalloc(nbuttons * sizeof(*p), GFP_KERNEL);
p = kmemdup(buttons, nbuttons * sizeof(*p), GFP_KERNEL);
if (!p)
return;

memcpy(p, buttons, nbuttons * sizeof(*p));

pdev = platform_device_alloc("gpio-keys-polled", id);
if (!pdev)
goto err_free_buttons;
Expand Down
4 changes: 1 addition & 3 deletions arch/mips/ath79/dev-leds-gpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,12 +24,10 @@ void __init ath79_register_leds_gpio(int id,
struct gpio_led *p;
int err;

p = kmalloc(num_leds * sizeof(*p), GFP_KERNEL);
p = kmemdup(leds, num_leds * sizeof(*p), GFP_KERNEL);
if (!p)
return;

memcpy(p, leds, num_leds * sizeof(*p));

pdev = platform_device_alloc("leds-gpio", id);
if (!pdev)
goto err_free_leds;
Expand Down

0 comments on commit 97bf7a1

Please sign in to comment.