Skip to content

Commit

Permalink
iop: Program outbound windows using the correct definitions
Browse files Browse the repository at this point in the history
The outbound translate registers should be programmed with the bus
addresses that are defined in the header files, rather than the
physical address.

Currently it doesn't matter because they're identical, but the headers
currently allow them to be different, and not using the right macros
here means that people are in for a surprise if they change them.

Cc: Lennert Buytenhek <kernel@wantstofly.org>
Acked-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
  • Loading branch information
Russell King authored and Dan Williams committed Mar 26, 2008
1 parent 27eedbf commit 97c4604
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions arch/arm/plat-iop/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -253,11 +253,11 @@ void __init iop3xx_atu_setup(void)
*IOP3XX_IATVR2 = PHYS_OFFSET;

/* Outbound window 0 */
*IOP3XX_OMWTVR0 = IOP3XX_PCI_LOWER_MEM_PA;
*IOP3XX_OMWTVR0 = IOP3XX_PCI_LOWER_MEM_BA;
*IOP3XX_OUMWTVR0 = 0;

/* Outbound window 1 */
*IOP3XX_OMWTVR1 = IOP3XX_PCI_LOWER_MEM_PA + IOP3XX_PCI_MEM_WINDOW_SIZE;
*IOP3XX_OMWTVR1 = IOP3XX_PCI_LOWER_MEM_BA + IOP3XX_PCI_MEM_WINDOW_SIZE;
*IOP3XX_OUMWTVR1 = 0;

/* BAR 3 ( Disabled ) */
Expand All @@ -268,7 +268,7 @@ void __init iop3xx_atu_setup(void)

/* Setup the I/O Bar
*/
*IOP3XX_OIOWTVR = IOP3XX_PCI_LOWER_IO_PA;;
*IOP3XX_OIOWTVR = IOP3XX_PCI_LOWER_IO_BA;

/* Enable inbound and outbound cycles
*/
Expand Down

0 comments on commit 97c4604

Please sign in to comment.