Skip to content

Commit

Permalink
netconsole: switch init_netconsole() to late_initcall
Browse files Browse the repository at this point in the history
Commit 88491d8(drivers/net: Kconfig & Makefile cleanup) causes a
regression that netconsole does not work if netconsole and network
device driver are build into kernel, because netconsole is linked
before network device driver.

Andrew Morton suggested to fix this with initcall ordering.
Fixes it by switching init_netconsole() to late_initcall.

Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Lin Ming authored and David S. Miller committed Sep 20, 2011
1 parent 710778f commit 97c7de0
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion drivers/net/netconsole.c
Original file line number Diff line number Diff line change
Expand Up @@ -799,5 +799,11 @@ static void __exit cleanup_netconsole(void)
}
}

module_init(init_netconsole);
/*
* Use late_initcall to ensure netconsole is
* initialized after network device driver if built-in.
*
* late_initcall() and module_init() are identical if built as module.
*/
late_initcall(init_netconsole);
module_exit(cleanup_netconsole);

0 comments on commit 97c7de0

Please sign in to comment.