Skip to content

Commit

Permalink
[PATCH] no need to wank with task_lock() and pinning task down in aud…
Browse files Browse the repository at this point in the history
…it_syscall_exit()

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed May 1, 2006
1 parent 5411be5 commit 97e94c4
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions kernel/auditsc.c
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,6 @@ static enum audit_state audit_filter_syscall(struct task_struct *tsk,
return AUDIT_BUILD_CONTEXT;
}

/* This should be called with task_lock() held. */
static inline struct audit_context *audit_get_context(struct task_struct *tsk,
int return_valid,
int return_code)
Expand Down Expand Up @@ -823,15 +822,10 @@ void audit_syscall_exit(int valid, long return_code)
struct task_struct *tsk = current;
struct audit_context *context;

get_task_struct(tsk);
task_lock(tsk);
context = audit_get_context(tsk, valid, return_code);
task_unlock(tsk);

/* Not having a context here is ok, since the parent may have
* called __put_task_struct. */
if (likely(!context))
goto out;
return;

if (context->in_syscall && context->auditable)
audit_log_exit(context, tsk);
Expand All @@ -849,8 +843,6 @@ void audit_syscall_exit(int valid, long return_code)
audit_free_aux(context);
tsk->audit_context = context;
}
out:
put_task_struct(tsk);
}

/**
Expand Down

0 comments on commit 97e94c4

Please sign in to comment.