Skip to content

Commit

Permalink
nfsd: do_probe_callback should not clear rpc stats
Browse files Browse the repository at this point in the history
Now that cb_stats are static (since commit
ff7d975)
there's no need to clear them.

Initially I thought it might make sense to do
that every callback probing but since the stats
are per-program and they are shared between possibly
several client callback instances, zeroing them out
seems like the wrong thing to do.

Note that that commit also introduced a bug
since stats.program is also being cleared in the process
and it is not restored after the memset as it used to be.

Signed-off-by: Benny Halevy <bhalevy@panasas.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
  • Loading branch information
Benny Halevy authored and J. Bruce Fields committed Sep 29, 2008
1 parent db820d6 commit 97eb89b
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions fs/nfsd/nfs4callback.c
Original file line number Diff line number Diff line change
Expand Up @@ -397,9 +397,6 @@ static int do_probe_callback(void *data)
addr.sin_port = htons(cb->cb_port);
addr.sin_addr.s_addr = htonl(cb->cb_addr);

/* Initialize rpc_stat */
memset(args.program->stats, 0, sizeof(struct rpc_stat));

/* Create RPC client */
client = rpc_create(&args);
if (IS_ERR(client)) {
Expand Down

0 comments on commit 97eb89b

Please sign in to comment.