Skip to content

Commit

Permalink
[POWERPC] Remove linux,device properties
Browse files Browse the repository at this point in the history
The linux,device property isn't used anywhere within the kernel, and
since it's a kernel pointer, it's a little useless for userspace.

This change removes the code to create this property in
of_device_register.

Built for pmac32.

Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Jeremy Kerr authored and Paul Mackerras committed Jul 7, 2006
1 parent 7ed14c2 commit 980ffd3
Showing 1 changed file with 0 additions and 24 deletions.
24 changes: 0 additions & 24 deletions arch/powerpc/kernel/of_device.c
Original file line number Diff line number Diff line change
Expand Up @@ -189,27 +189,9 @@ void of_release_dev(struct device *dev)
int of_device_register(struct of_device *ofdev)
{
int rc;
struct of_device **odprop;

BUG_ON(ofdev->node == NULL);

odprop = (struct of_device **)get_property(ofdev->node, "linux,device", NULL);
if (!odprop) {
struct property *new_prop;

new_prop = kmalloc(sizeof(struct property) + sizeof(struct of_device *),
GFP_KERNEL);
if (new_prop == NULL)
return -ENOMEM;
new_prop->name = "linux,device";
new_prop->length = sizeof(sizeof(struct of_device *));
new_prop->value = (unsigned char *)&new_prop[1];
odprop = (struct of_device **)new_prop->value;
*odprop = NULL;
prom_add_property(ofdev->node, new_prop);
}
*odprop = ofdev;

rc = device_register(&ofdev->dev);
if (rc)
return rc;
Expand All @@ -221,14 +203,8 @@ int of_device_register(struct of_device *ofdev)

void of_device_unregister(struct of_device *ofdev)
{
struct of_device **odprop;

device_remove_file(&ofdev->dev, &dev_attr_devspec);

odprop = (struct of_device **)get_property(ofdev->node, "linux,device", NULL);
if (odprop)
*odprop = NULL;

device_unregister(&ofdev->dev);
}

Expand Down

0 comments on commit 980ffd3

Please sign in to comment.