Skip to content

Commit

Permalink
dm crypt: fix avoid cloned bio ref after free
Browse files Browse the repository at this point in the history
Do not access the bio after generic_make_request

We should never access a bio after generic_make_request - there's no guarantee
it still exists.

Signed-off-by: Olaf Kirch <olaf.kirch@oracle.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
Cc: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Olaf Kirch authored and Linus Torvalds committed May 9, 2007
1 parent 027581f commit 98221eb
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion drivers/md/dm-crypt.c
Original file line number Diff line number Diff line change
Expand Up @@ -655,9 +655,12 @@ static void process_write(struct crypt_io *io)

generic_make_request(clone);

/* Do not reference clone after this - it
* may be gone already. */

/* out of memory -> run queues */
if (remaining)
congestion_wait(bio_data_dir(clone), HZ/100);
congestion_wait(WRITE, HZ/100);
}
}

Expand Down

0 comments on commit 98221eb

Please sign in to comment.