Skip to content

Commit

Permalink
drivers: platform: change 0x20 to I8042_STR_AUXDATA in i8042 filters
Browse files Browse the repository at this point in the history
Instead of using a magic constant 0x20 in some drivers to get data only
from the KBC port we should use the constant defined in i8042.h with
the same value. Also, this makes these drivers uniform with what
constant the only other filter function uses in
drivers/input/misc/ideapad_slidebar.c.

Signed-off-by: Giedrius Statkevičius <giedriuswork@gmail.com>
Signed-off-by: Darren Hart <dvhart@linux.intel.com>
  • Loading branch information
Giedrius Statkevičius authored and Darren Hart committed Nov 19, 2014
1 parent fc14f9c commit 9828037
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion drivers/platform/x86/dell-laptop.c
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ static bool dell_laptop_i8042_filter(unsigned char data, unsigned char str,
{
static bool extended;

if (str & 0x20)
if (str & I8042_STR_AUXDATA)
return false;

if (unlikely(data == 0xe0)) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/platform/x86/msi-laptop.c
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,7 @@ static bool msi_laptop_i8042_filter(unsigned char data, unsigned char str,
{
static bool extended;

if (str & 0x20)
if (str & I8042_STR_AUXDATA)
return false;

/* 0x54 wwan, 0x62 bluetooth, 0x76 wlan, 0xE4 touchpad toggle*/
Expand Down
2 changes: 1 addition & 1 deletion drivers/platform/x86/toshiba_acpi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1589,7 +1589,7 @@ static umode_t toshiba_sysfs_is_visible(struct kobject *kobj,
static bool toshiba_acpi_i8042_filter(unsigned char data, unsigned char str,
struct serio *port)
{
if (str & 0x20)
if (str & I8042_STR_AUXDATA)
return false;

if (unlikely(data == 0xe0))
Expand Down

0 comments on commit 9828037

Please sign in to comment.