Skip to content

Commit

Permalink
V4L/DVB (10986): mr97310a: don't discard frame headers on stream output
Browse files Browse the repository at this point in the history
Fix a bug where all frame headers were being discarded, instead of being part of the
stream output, on MR97310A cameras.

The frame headers contain information which may be useful in processing
the video output and therefore should be kept and not discarded.

A corresponding patch to the decompression algorithm in
libv4lconvert/mr97310a.c corrects the change in frame offset.

Signed-off-by: Theodore Kilgore <kilgota@auburn.edu>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Theodore Kilgore authored and Mauro Carvalho Chehab committed Mar 30, 2009
1 parent 9f9cd8f commit 9832d76
Showing 1 changed file with 3 additions and 19 deletions.
22 changes: 3 additions & 19 deletions drivers/media/video/gspca/mr97310a.c
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,7 @@ MODULE_LICENSE("GPL");
/* specific webcam descriptor */
struct sd {
struct gspca_dev gspca_dev; /* !! must be the first item */

u8 sof_read;
u8 header_read;
};

/* V4L2 controls supported by the driver */
Expand Down Expand Up @@ -285,7 +283,6 @@ static void sd_pkt_scan(struct gspca_dev *gspca_dev,
__u8 *data, /* isoc packet */
int len) /* iso packet length */
{
struct sd *sd = (struct sd *) gspca_dev;
unsigned char *sof;

sof = pac_find_sof(gspca_dev, data, len);
Expand All @@ -300,25 +297,12 @@ static void sd_pkt_scan(struct gspca_dev *gspca_dev,
n = 0;
frame = gspca_frame_add(gspca_dev, LAST_PACKET, frame,
data, n);
sd->header_read = 0;
gspca_frame_add(gspca_dev, FIRST_PACKET, frame, NULL, 0);
/* Start next frame. */
gspca_frame_add(gspca_dev, FIRST_PACKET, frame,
pac_sof_marker, sizeof pac_sof_marker);
len -= sof - data;
data = sof;
}
if (sd->header_read < 7) {
int needed;

/* skip the rest of the header */
needed = 7 - sd->header_read;
if (len <= needed) {
sd->header_read += len;
return;
}
data += needed;
len -= needed;
sd->header_read = 7;
}

gspca_frame_add(gspca_dev, INTER_PACKET, frame, data, len);
}

Expand Down

0 comments on commit 9832d76

Please sign in to comment.