Skip to content

Commit

Permalink
bnx2x: Remove redundant smb_mb on unload
Browse files Browse the repository at this point in the history
As noted by Ben Hutchings <bhutchings@solarflare.com>, these smb_mb are not
needed

Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eilon Greenstein authored and David S. Miller committed Mar 3, 2009
1 parent a8c9a53 commit 98589bb
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions drivers/net/bnx2x_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -7210,7 +7210,6 @@ static int bnx2x_nic_unload(struct bnx2x *bp, int unload_mode)
struct bnx2x_fastpath *fp = &bp->fp[i];

cnt = 1000;
smp_mb();
while (bnx2x_has_tx_work_unload(fp)) {

bnx2x_tx_int(fp, 1000);
Expand All @@ -7226,7 +7225,6 @@ static int bnx2x_nic_unload(struct bnx2x *bp, int unload_mode)
}
cnt--;
msleep(1);
smp_mb();
}
}
/* Give HW time to discard old tx messages */
Expand Down

0 comments on commit 98589bb

Please sign in to comment.