Skip to content

Commit

Permalink
---
Browse files Browse the repository at this point in the history
yaml
---
r: 176777
b: refs/heads/master
c: 327ae59
h: refs/heads/master
i:
  176775: 7ea94ed
v: v3
  • Loading branch information
Laurent Pinchart authored and Mauro Carvalho Chehab committed Dec 16, 2009
1 parent 854549c commit 988187d
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 43 deletions.
2 changes: 1 addition & 1 deletion [refs]
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
---
refs/heads/master: 46b21094cee16bc7e531d7d6cd66fb5ea05065d4
refs/heads/master: 327ae59757f2e56fd3fc2b11acbd0a7c4070f4e8
19 changes: 0 additions & 19 deletions trunk/drivers/media/common/saa7146_fops.c
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
#include <media/saa7146_vv.h>

#define BOARD_CAN_DO_VBI(dev) (dev->revision != 0 && dev->vv_data->vbi_minor != -1)

/****************************************************************************/
/* resource management functions, shamelessly stolen from saa7134 driver */

Expand Down Expand Up @@ -455,9 +453,6 @@ int saa7146_vv_init(struct saa7146_dev* dev, struct saa7146_ext_vv *ext_vv)
configuration data) */
dev->ext_vv_data = ext_vv;

vv->video_minor = -1;
vv->vbi_minor = -1;

vv->d_clipping.cpu_addr = pci_alloc_consistent(dev->pci, SAA7146_CLIPPING_MEM, &vv->d_clipping.dma_handle);
if( NULL == vv->d_clipping.cpu_addr ) {
ERR(("out of memory. aborting.\n"));
Expand Down Expand Up @@ -496,7 +491,6 @@ EXPORT_SYMBOL_GPL(saa7146_vv_release);
int saa7146_register_device(struct video_device **vid, struct saa7146_dev* dev,
char *name, int type)
{
struct saa7146_vv *vv = dev->vv_data;
struct video_device *vfd;
int err;
int i;
Expand Down Expand Up @@ -524,11 +518,6 @@ int saa7146_register_device(struct video_device **vid, struct saa7146_dev* dev,
return err;
}

if (VFL_TYPE_GRABBER == type)
vv->video_minor = vfd->minor;
else
vv->vbi_minor = vfd->minor;

INFO(("%s: registered device %s [v4l2]\n",
dev->name, video_device_node_name(vfd)));

Expand All @@ -539,16 +528,8 @@ EXPORT_SYMBOL_GPL(saa7146_register_device);

int saa7146_unregister_device(struct video_device **vid, struct saa7146_dev* dev)
{
struct saa7146_vv *vv = dev->vv_data;

DEB_EE(("dev:%p\n",dev));

if ((*vid)->vfl_type == VFL_TYPE_GRABBER) {
vv->video_minor = -1;
} else {
vv->vbi_minor = -1;
}

video_unregister_device(*vid);
*vid = NULL;

Expand Down
4 changes: 0 additions & 4 deletions trunk/drivers/media/radio/radio-tea5764.c
Original file line number Diff line number Diff line change
Expand Up @@ -460,12 +460,8 @@ static int vidioc_s_audio(struct file *file, void *priv,
static int tea5764_open(struct file *file)
{
/* Currently we support only one device */
int minor = video_devdata(file)->minor;
struct tea5764_device *radio = video_drvdata(file);

if (radio->videodev->minor != minor)
return -ENODEV;

mutex_lock(&radio->mutex);
/* Only exclusive access */
if (radio->users) {
Expand Down
15 changes: 4 additions & 11 deletions trunk/drivers/media/video/bt8xx/bttv-driver.c
Original file line number Diff line number Diff line change
Expand Up @@ -3206,25 +3206,24 @@ static unsigned int bttv_poll(struct file *file, poll_table *wait)

static int bttv_open(struct file *file)
{
int minor = video_devdata(file)->minor;
struct video_device *vdev = video_devdata(file);
struct bttv *btv = video_drvdata(file);
struct bttv_fh *fh;
enum v4l2_buf_type type = 0;

dprintk(KERN_DEBUG "bttv: open dev=%s\n", video_device_node_name(vdev));

lock_kernel();
if (btv->video_dev->minor == minor) {
if (vdev->vfl_type == VFL_TYPE_GRABBER) {
type = V4L2_BUF_TYPE_VIDEO_CAPTURE;
} else if (btv->vbi_dev->minor == minor) {
} else if (vdev->vfl_type == VFL_TYPE_VBI) {
type = V4L2_BUF_TYPE_VBI_CAPTURE;
} else {
WARN_ON(1);
unlock_kernel();
return -ENODEV;
}

lock_kernel();

dprintk(KERN_DEBUG "bttv%d: open called (type=%s)\n",
btv->c.nr,v4l2_type_names[type]);

Expand Down Expand Up @@ -3408,19 +3407,13 @@ static struct video_device bttv_video_template = {

static int radio_open(struct file *file)
{
int minor = video_devdata(file)->minor;
struct video_device *vdev = video_devdata(file);
struct bttv *btv = video_drvdata(file);
struct bttv_fh *fh;

dprintk("bttv: open dev=%s\n", video_device_node_name(vdev));

lock_kernel();
WARN_ON(btv->radio_dev && btv->radio_dev->minor != minor);
if (!btv->radio_dev || btv->radio_dev->minor != minor) {
unlock_kernel();
return -ENODEV;
}

dprintk("bttv%d: open called (radio)\n",btv->c.nr);

Expand Down
5 changes: 3 additions & 2 deletions trunk/drivers/media/video/gspca/sn9c20x.c
Original file line number Diff line number Diff line change
Expand Up @@ -1476,8 +1476,9 @@ static int sn9c20x_input_init(struct gspca_dev *gspca_dev)
if (input_register_device(sd->input_dev))
return -EINVAL;

sd->input_task = kthread_run(input_kthread, gspca_dev, "sn9c20x/%d",
gspca_dev->vdev.minor);
sd->input_task = kthread_run(input_kthread, gspca_dev, "sn9c20x/%s-%s",
gspca_dev->dev->bus->bus_name,
gspca_dev->dev->devpath);

if (IS_ERR(sd->input_task))
return -EINVAL;
Expand Down
3 changes: 1 addition & 2 deletions trunk/drivers/media/video/omap24xxcam.c
Original file line number Diff line number Diff line change
Expand Up @@ -1450,12 +1450,11 @@ static int omap24xxcam_mmap(struct file *file, struct vm_area_struct *vma)

static int omap24xxcam_open(struct file *file)
{
int minor = video_devdata(file)->minor;
struct omap24xxcam_device *cam = omap24xxcam.priv;
struct omap24xxcam_fh *fh;
struct v4l2_format format;

if (!cam || !cam->vfd || (cam->vfd->minor != minor))
if (!cam || !cam->vfd)
return -ENODEV;

fh = kzalloc(sizeof(*fh), GFP_KERNEL);
Expand Down
4 changes: 0 additions & 4 deletions trunk/include/media/saa7146_vv.h
Original file line number Diff line number Diff line change
Expand Up @@ -108,17 +108,13 @@ struct saa7146_fh {

struct saa7146_vv
{
int vbi_minor;

/* vbi capture */
struct saa7146_dmaqueue vbi_q;
/* vbi workaround interrupt queue */
wait_queue_head_t vbi_wq;
int vbi_fieldcount;
struct saa7146_fh *vbi_streaming;

int video_minor;

int video_status;
struct saa7146_fh *video_fh;

Expand Down

0 comments on commit 988187d

Please sign in to comment.