Skip to content

Commit

Permalink
[POWERPC] Use of_get_next_parent() in platforms/cell/axon_msi.c
Browse files Browse the repository at this point in the history
Replace two open-coded occurences of the of_get_next_parent() logic.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Paul Mackerras <paulus@samba.org>
  • Loading branch information
Michael Ellerman authored and Paul Mackerras committed Apr 24, 2008
1 parent 5c02cd2 commit 988479e
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions arch/powerpc/platforms/cell/axon_msi.c
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ static struct axon_msic *find_msi_translator(struct pci_dev *dev)
return NULL;
}

for (; dn; tmp = of_get_parent(dn), of_node_put(dn), dn = tmp) {
for (; dn; dn = of_get_next_parent(dn)) {
ph = of_get_property(dn, "msi-translator", NULL);
if (ph)
break;
Expand Down Expand Up @@ -169,7 +169,7 @@ static int axon_msi_check_device(struct pci_dev *dev, int nvec, int type)

static int setup_msi_msg_address(struct pci_dev *dev, struct msi_msg *msg)
{
struct device_node *dn, *tmp;
struct device_node *dn;
struct msi_desc *entry;
int len;
const u32 *prop;
Expand All @@ -182,7 +182,7 @@ static int setup_msi_msg_address(struct pci_dev *dev, struct msi_msg *msg)

entry = list_first_entry(&dev->msi_list, struct msi_desc, list);

for (; dn; tmp = of_get_parent(dn), of_node_put(dn), dn = tmp) {
for (; dn; dn = of_get_next_parent(dn)) {
if (entry->msi_attrib.is_64) {
prop = of_get_property(dn, "msi-address-64", &len);
if (prop)
Expand Down

0 comments on commit 988479e

Please sign in to comment.