Skip to content

Commit

Permalink
f2fs: fix memory leak when init f2fs filesystem fail
Browse files Browse the repository at this point in the history
When any of the caches create fails in init_f2fs_fs(), the other caches which are
create successful should be free.

Signed-off-by: Zhao Hongjiang <zhaohongjiang@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
  • Loading branch information
Zhao Hongjiang authored and Jaegeuk Kim committed Aug 20, 2013
1 parent 7b40527 commit 9890ff3
Showing 1 changed file with 17 additions and 5 deletions.
22 changes: 17 additions & 5 deletions fs/f2fs/super.c
Original file line number Diff line number Diff line change
Expand Up @@ -1004,21 +1004,33 @@ static int __init init_f2fs_fs(void)
goto fail;
err = create_node_manager_caches();
if (err)
goto fail;
goto free_inodecache;
err = create_gc_caches();
if (err)
goto fail;
goto free_node_manager_caches;
err = create_checkpoint_caches();
if (err)
goto fail;
goto free_gc_caches;
f2fs_kset = kset_create_and_add("f2fs", NULL, fs_kobj);
if (!f2fs_kset)
goto fail;
goto free_checkpoint_caches;
err = register_filesystem(&f2fs_fs_type);
if (err)
goto fail;
goto free_kset;
f2fs_create_root_stats();
f2fs_proc_root = proc_mkdir("fs/f2fs", NULL);
return 0;

free_kset:
kset_unregister(f2fs_kset);
free_checkpoint_caches:
destroy_checkpoint_caches();
free_gc_caches:
destroy_gc_caches();
free_node_manager_caches:
destroy_node_manager_caches();
free_inodecache:
destroy_inodecache();
fail:
return err;
}
Expand Down

0 comments on commit 9890ff3

Please sign in to comment.