Skip to content

Commit

Permalink
e1000e: fix skb truesize underestimation
Browse files Browse the repository at this point in the history
e1000e allocates a page per skb fragment. We must account
PAGE_SIZE increments on skb->truesize, not the actual frag length.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
CC: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eric Dumazet authored and David S. Miller committed Oct 13, 2011
1 parent 9813064 commit 98a045d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/ethernet/intel/e1000e/netdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -1300,7 +1300,7 @@ static bool e1000_clean_rx_irq_ps(struct e1000_adapter *adapter,
ps_page->page = NULL;
skb->len += length;
skb->data_len += length;
skb->truesize += length;
skb->truesize += PAGE_SIZE;
}

/* strip the ethernet crc, problem is we're using pages now so
Expand Down Expand Up @@ -1360,7 +1360,7 @@ static void e1000_consume_page(struct e1000_buffer *bi, struct sk_buff *skb,
bi->page = NULL;
skb->len += length;
skb->data_len += length;
skb->truesize += length;
skb->truesize += PAGE_SIZE;
}

/**
Expand Down

0 comments on commit 98a045d

Please sign in to comment.