Skip to content

Commit

Permalink
[TIPC]: Fix semaphore handling.
Browse files Browse the repository at this point in the history
As noted by Kevin, tipc's release() does down_interruptible() and
ignores the return value.  So if signal_pending() we'll end up doing
up() on a non-downed semaphore.  Fix.

Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Andrew Morton authored and David S. Miller committed Dec 14, 2007
1 parent cbebc51 commit 98eb568
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/tipc/socket.c
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ static int release(struct socket *sock)
dbg("sock_delete: %x\n",tsock);
if (!tsock)
return 0;
down_interruptible(&tsock->sem);
down(&tsock->sem);
if (!sock->sk) {
up(&tsock->sem);
return 0;
Expand Down

0 comments on commit 98eb568

Please sign in to comment.