Skip to content

Commit

Permalink
AUDIT: Return correct result from audit_filter_rules()
Browse files Browse the repository at this point in the history
When the task refcounting was added to audit_filter_rules() it became
more of a problem that this function was violating the 'only one 
return from each function' rule. In fixing it to use a variable to store 
'ret' I stupidly neglected to actually change the 'return 1;' at the 
end. This makes it not work very well.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
  • Loading branch information
David Woodhouse committed Jun 24, 2005
1 parent 9e94e66 commit 993e2d4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/auditsc.c
Original file line number Diff line number Diff line change
Expand Up @@ -557,7 +557,7 @@ int audit_filter_user(int pid, int type)
rcu_read_unlock();
put_task_struct(tsk);

return 1; /* Audit by default */
return ret; /* Audit by default */

}

Expand Down

0 comments on commit 993e2d4

Please sign in to comment.