Skip to content

Commit

Permalink
acer-wmi: Blacklist backlight on Acer Aspire 1520 & 1360 series
Browse files Browse the repository at this point in the history
A newer BIOS for these laptops adds ACPI-WMI support to them. However, it does
not add support for the backlight via the EC, and we have no way to detect
this on older machines, so blacklist it from them.

Signed-off-by: Carlos Corbacho <carlos@strangeworlds.co.uk>
Signed-off-by: Len Brown <len.brown@intel.com>
Signed-off-by: Andi Kleen <ak@linux.intel.com>
  • Loading branch information
Carlos Corbacho authored and Andi Kleen committed Jul 16, 2008
1 parent a0bbaf8 commit 9991d9f
Showing 1 changed file with 27 additions and 4 deletions.
31 changes: 27 additions & 4 deletions drivers/misc/acer-wmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ static struct wmi_interface *interface;
struct quirk_entry {
u8 wireless;
u8 mailled;
u8 brightness;
s8 brightness;
u8 bluetooth;
};

Expand All @@ -198,6 +198,10 @@ static int dmi_matched(const struct dmi_system_id *dmi)
static struct quirk_entry quirk_unknown = {
};

static struct quirk_entry quirk_acer_aspire_1520 = {
.brightness = -1,
};

static struct quirk_entry quirk_acer_travelmate_2490 = {
.mailled = 1,
};
Expand All @@ -208,6 +212,24 @@ static struct quirk_entry quirk_medion_md_98300 = {
};

static struct dmi_system_id acer_quirks[] = {
{
.callback = dmi_matched,
.ident = "Acer Aspire 1360",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 1360"),
},
.driver_data = &quirk_acer_aspire_1520,
},
{
.callback = dmi_matched,
.ident = "Acer Aspire 1520",
.matches = {
DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 1520"),
},
.driver_data = &quirk_acer_aspire_1520,
},
{
.callback = dmi_matched,
.ident = "Acer Aspire 3100",
Expand Down Expand Up @@ -552,7 +574,8 @@ static acpi_status AMW0_set_capabilities(void)
* appear to use the same EC register for brightness, even if they
* differ for wireless, etc
*/
interface->capability |= ACER_CAP_BRIGHTNESS;
if (quirks->brightness >= 0)
interface->capability |= ACER_CAP_BRIGHTNESS;

return AE_OK;
}
Expand Down Expand Up @@ -1059,6 +1082,8 @@ static int __init acer_wmi_init(void)
printk(ACER_INFO "Acer Laptop ACPI-WMI Extras version %s\n",
ACER_WMI_VERSION);

find_quirks();

/*
* Detect which ACPI-WMI interface we're using.
*/
Expand Down Expand Up @@ -1092,8 +1117,6 @@ static int __init acer_wmi_init(void)
if (wmi_has_guid(AMW0_GUID1))
AMW0_find_mailled();

find_quirks();

if (!interface) {
printk(ACER_ERR "No or unsupported WMI interface, unable to "
"load\n");
Expand Down

0 comments on commit 9991d9f

Please sign in to comment.